Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topology Processor: Components with single bus are ignored (#2309) #2310

Merged
merged 5 commits into from
Oct 5, 2022
Merged

Topology Processor: Components with single bus are ignored (#2309) #2310

merged 5 commits into from
Oct 5, 2022

Conversation

jeandemanged
Copy link
Member

Signed-off-by: Damien Jeandemange damien.jeandemange@artelys.com

Please check if the PR fulfills these requirements (please use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes)

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem ? If so, link to this issue using '#XXX' and skip the rest
Reproduce #2309

@jeandemanged
Topology Processor: Components with single bus are ignored (#2309)
9515f59 
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@jeandemanged jeandemanged mentioned this pull request Oct 2, 2022
Closed
@jeandemanged jeandemanged linked an issue Oct 3, 2022 that may be closed by this pull request
Topology Processor: Components with single bus are ignored #2309
Closed
@annetill
Copy link
Member

annetill commented Oct 3, 2022 •
edited
Loading

#1316

We have tried to fix the bus definition from a node/breaker topology and from a bus/breaker topology in the past. The definition is not equivalent and I think that it is really a bug. Thanks for reopening this issue. @geofjamg and @sylvlecl any opinion about that?

@annetill
Fix proposal.
fc9d7c8 
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@annetill annetill requested a review from zamarrenolm October 3, 2022 18:21
@annetill annetill changed the title [WIP] Topology Processor: Components with single bus are ignored (#2309) Topology Processor: Components with single bus are ignored (#2309) Oct 4, 2022
@annetill annetill marked this pull request as ready for review October 4, 2022 07:08
@zamarrenolm
add comment to ignored unit test case
6c02cbf 
Signed-off-by: Luma <zamarrenolm@aia.es>
@zamarrenolm zamarrenolm mentioned this pull request Oct 4, 2022
Open
@jeandemanged
removed FIXME comment in ComponentsTest
6c2154b 
Signed-off-by: Damien Jeandemange <damien.jeandemange@artelys.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@miovd miovd merged commit 79eb410 into main Oct 5, 2022
@miovd miovd deleted the single-bus-components branch October 5, 2022 07:03
@Mathieu-Deharbe Mathieu-Deharbe mentioned this pull request Aug 19, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annetill annetill annetill left review comments

@geofjamg geofjamg geofjamg approved these changes

@zamarrenolm zamarrenolm zamarrenolm approved these changes

@miovd miovd miovd approved these changes

Assignees
No one assigned
Labels
PR: ready-to-be-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Topology Processor: Components with single bus are ignored
5 participants
@jeandemanged @annetill @geofjamg @zamarrenolm @miovd