Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Testing workflow improvements #304

Merged
merged 4 commits into from
May 7, 2024
Merged

Feature/Testing workflow improvements #304

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
45fdb72
Run tests when a PR is updated or re-opened.
gentique Feb 2, 2024
26f9654
Replace cancel action with native concurrency option.
gentique Feb 2, 2024
da7d12f
Update checkout to v4.
gentique Feb 2, 2024
579ff99
Replace `xcpretty` with `xcbeautify` to show annotations in actions s…
gentique Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/Tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,26 +3,27 @@ name: Tests
on:
push:
pull_request:
types: [opened]
types: [ opened, synchronize, reopened ]

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true
Comment on lines +8 to +10
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think concurrency doesn't work on m1 runners.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out, following builds got canceled automatically (pushed a temporary commit & dropped it right after):

Superseded by: https://github.com/poviolabs/PovioKit/actions/runs/7791435474


jobs:
Tests:
runs-on: macos-13
steps:
- name: Cancel previous jobs
uses: styfle/cancel-workflow-action@0.11.0

- name: Checkout Repository
uses: actions/checkout@v3
uses: actions/checkout@v4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌


- name: Load Latest Xcode
uses: maxim-lobanov/setup-xcode@v1
with:
xcode-version: latest-stable

- name: Build project
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild build-for-testing -destination 'name=iPhone 14 Pro' -scheme 'PovioKit-Package' | xcpretty
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild build-for-testing -destination 'name=iPhone 14 Pro' -scheme 'PovioKit-Package' | xcbeautify --renderer github-actions

- name: Run tests
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild test-without-building -destination 'name=iPhone 14 Pro' -scheme 'PovioKit-Package' | xcpretty
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild test-without-building -destination 'name=iPhone 14 Pro' -scheme 'PovioKit-Package' | xcbeautify --renderer github-actions
Comment on lines -24 to +28
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already catching compiler warnings, soon to be errors with Swift 6:
Screenshot 2024-02-05 at 11 10 51 PM


Loading