Feature/Testing workflow improvements #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markom-povio
approved these changes
Feb 2, 2024
borut-t
approved these changes
Feb 5, 2024
Comment on lines
+8
to
+10
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
I think concurrency doesn't work on m1 runners.
There was a problem hiding this comment.
Tested it out, following builds got canceled automatically (pushed a temporary commit & dropped it right after):
- https://github.com/poviolabs/PovioKit/actions/runs/7791423664
- https://github.com/poviolabs/PovioKit/actions/runs/7791411933
Superseded by: https://github.com/poviolabs/PovioKit/actions/runs/7791435474
| - name: Checkout Repository | ||
| uses: actions/checkout@v3 | ||
| uses: actions/checkout@v4 |
Comment on lines
-24
to
+28
| run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild build-for-testing -destination 'name=iPhone 14 Pro' -scheme 'PovioKit-Package' | xcpretty | ||
| run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild build-for-testing -destination 'name=iPhone 14 Pro' -scheme 'PovioKit-Package' | xcbeautify --renderer github-actions | ||
|
|
||
| - name: Run tests | ||
| run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild test-without-building -destination 'name=iPhone 14 Pro' -scheme 'PovioKit-Package' | xcpretty | ||
| run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild test-without-building -destination 'name=iPhone 14 Pro' -scheme 'PovioKit-Package' | xcbeautify --renderer github-actions |
There was a problem hiding this comment.
This is already catching compiler warnings, soon to be errors with Swift 6:
gentique
force-pushed
the
feature/testing-workflow-improvements
branch
2 times, most recently
from
4b04cee to
579ff99
Compare
|
@borut-t feel free to merge. |
borut-t
changed the title
borut-t
pushed a commit
that referenced
this pull request
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey-ya 👋,
Added some minor changes & improvements:
styfle/cancel-workflow-actionwithconcurrency, does same thing just more native.checkoutaction to latest to alleviate warnings.xcprettywithxcbeautify, is up to 2x faster & has the option to show annotations(warnings, test results) directly on the summary.