Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minexponent attribute to control usage of SI prefixes in axis ticks #5121

Merged
merged 15 commits into from
Sep 26, 2020
Merged

Add minexponent attribute to control usage of SI prefixes in axis ticks #5121

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
98c6937
Add `eng` exponentformat for engineering notation
Aug 27, 2020
65ae0f0
Create new axis attribute `minexponent`
Sep 1, 2020
c27653c
Add tests for `minexponent` attribute
Sep 3, 2020
f74e17f
minexponent test: do not redeclare textOut
Sep 3, 2020
83273cf
minexponent: add minimum value
Sep 3, 2020
f171cb6
axes_test mockCalc: add default value to minexponent attribute
Sep 4, 2020
cb6ffef
traces/carpet/axis_attributes: set minexponent editType to `calc`
Sep 4, 2020
1322729
axes_test: fix SyntaxError
ignamv Sep 4, 2020
16d1a16
mockCalc: ensure ax is modified in-place
Sep 7, 2020
ba408aa
axes_test: fix SyntaxError
Sep 7, 2020
dc565d9
autoTickRound: use default minexponent if undefined
Sep 7, 2020
d90b39b
axes_test: remove redundant setting of minexponent
ignamv Sep 13, 2020
2da1972
mockColorBarAxis: pass minexponent attribute
ignamv Sep 26, 2020
f504f6c
Layout attribute docs: expand description for `minexponent`
ignamv Sep 26, 2020
99b2769
Fix syntax error
ignamv Sep 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/plots/cartesian/axes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,7 +1042,8 @@ function autoTickRound(ax) {

var maxend = Math.max(Math.abs(rng[0]), Math.abs(rng[1]));
var rangeexp = Math.floor(Math.log(maxend) / Math.LN10 + 0.01);
if(Math.abs(rangeexp) > ax.minexponent) {
var minexponent = ax.minexponent === undefined ? 3 : ax.minexponent;
if(Math.abs(rangeexp) > minexponent) {
if(isSIFormat(ax.exponentformat) && !beyondSI(rangeexp)) {
ax._tickexponent = 3 * Math.round((rangeexp - 1) / 3);
} else ax._tickexponent = rangeexp;
Expand Down