Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add Swahili localization support #2526

Merged
merged 4 commits into from
Apr 27, 2018
Merged

feat(locale): add Swahili localization support #2526

merged 4 commits into from
Apr 27, 2018

Conversation

booleanbetrayal
Copy link
Contributor

No description provided.

@alexcjohnson
Copy link
Collaborator

Thanks @booleanbetrayal ! Can I ask you though (as mentioned in the PR template) to update lib/locales/ and not dist? The ones in dist/ are automatically generated, and unreadable since they're minified.

@booleanbetrayal
Copy link
Contributor Author

updated in a rebase @alexcjohnson

@alexcjohnson
Copy link
Collaborator

Thanks - I just made a couple of changes to put the format on par with the others in /lib/locales/, but otherwise looks perfect now! Can you find another Swahili speaker who can review this? They need not be a plotly user, nor even technical though that does help. Even if they can just look at https://github.com/plotly/plotly.js/pull/2526/files?diff=unified and give you some offline feedback like we did with czech that would suffice.

@booleanbetrayal
Copy link
Contributor Author

The hover-tooltips and month / day names were professionally reviewed by a paid translation service back when we were doing our own localization implementation. The rest have been machine-translated.

The Plotly.js locales were back-ported for consistency. I don't actually know of any Swahili speakers personally. How do you usually solicit for help for these things?

@alexcjohnson
Copy link
Collaborator

Got it. The professionally reviewed ones should be great, and that set (dates & hover tips) covers arguably the most important ones. I'm a little uneasy with machine translation though, if it hasn't been reviewed by a human. Are you doing this for a customer who might be willing to help out? I can keep asking around but so far have not found any Swahili speakers in my own network.

@booleanbetrayal
Copy link
Contributor Author

I wish I had access to some customers, but I don't. We're no longer targeting the market segment that brought us those speakers, but would like to continue supporting the locale, just in case. Trying to simplify our codebase and get us up to speed with Plotly.js localization support and this backfill makes life easier. I'd be happy to chip in a few bucks to help pay for a general professional translations services' pass, though.

@alexcjohnson
Copy link
Collaborator

Good news! We've found a Swahili speaker - @kndungu has offered to review. 🎉

@booleanbetrayal
Copy link
Contributor Author

Awesome -- thanks @kndungu !

Copy link

@kndungu kndungu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A pretty good job had already been done, made it that much easier.

name: 'sw',
dictionary: {
'Autoscale': 'Kigezo - otomatiki',
'Box Select': 'Kuteua kisanduku',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The better translation would be Teua kisanduku

dictionary: {
'Autoscale': 'Kigezo - otomatiki',
'Box Select': 'Kuteua kisanduku',
'Click to enter Colorscale title': 'Bonyeza kuingia kichwa cha Colorscale',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonyeza kuandika kichwa cha Colorscale

'Autoscale': 'Kigezo - otomatiki',
'Box Select': 'Kuteua kisanduku',
'Click to enter Colorscale title': 'Bonyeza kuingia kichwa cha Colorscale',
'Click to enter Component A title': 'Bofya ili uingize kichwa cha A kichwa',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonyeza kuandika kichwa cha sehemu A

'Box Select': 'Kuteua kisanduku',
'Click to enter Colorscale title': 'Bonyeza kuingia kichwa cha Colorscale',
'Click to enter Component A title': 'Bofya ili uingize kichwa cha A kichwa',
'Click to enter Component B title': 'Bofya ili uingize kichwa cha B kichwa',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonyeza kuandika kichwa cha sehemu B

'Click to enter Colorscale title': 'Bonyeza kuingia kichwa cha Colorscale',
'Click to enter Component A title': 'Bofya ili uingize kichwa cha A kichwa',
'Click to enter Component B title': 'Bofya ili uingize kichwa cha B kichwa',
'Click to enter Component C title': 'Bofya ili uingize kichwa cha C kichwa',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonyeza kuandika kichwa cha sehemu C

'Lasso Select': 'Kuteua lasso',
'Orbital rotation': 'Mzunguko wa mazao',
'Pan': 'Tandaza',
'Produced with Plotly': 'Iliyotokana na Plotly',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ilitengenezwa na Plotly

'Double-click to zoom back out': 'Bonyeza mara mbili ili uongeze tena',
'Download plot as a png': 'Pakua mpango kama png',
'Edit in Chart Studio': 'Badilisha katika Studio ya Chati',
'IE only supports svg. Changing format to svg.': 'IE inasaidia tu svg. Kubadili muundo kwa svg.',
Copy link

@kndungu kndungu Apr 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IE inatumia tu svg. Tunabadilisha muundo kuwa svg.

'Double-click on legend to isolate one trace': 'Bonyeza mara mbili juu ya hadithi ili kutenganisha moja kwa moja',
'Double-click to zoom back out': 'Bonyeza mara mbili ili uongeze tena',
'Download plot as a png': 'Pakua mpango kama png',
'Edit in Chart Studio': 'Badilisha katika Studio ya Chati',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hariri katika Chart studio

'Click to enter radial axis title': 'Bonyeza kuingia kichwa cha mhimili wa radial',
'Compare data on hover': 'Linganisha data kielekezi kinapoelea',
'Double-click on legend to isolate one trace': 'Bonyeza mara mbili juu ya hadithi ili kutenganisha moja kwa moja',
'Double-click to zoom back out': 'Bonyeza mara mbili ili uongeze tena',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bonyeza mara mbili ili kuvuta nje

shortDays: ['Sun', 'Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat'],
months: ['Januari', 'Februari', 'Machi', 'Aprili', 'Mei', 'Juni', 'Julai', 'Agosti', 'Septemba', 'Oktoba', 'Novemba', 'Desemba'],
shortMonths: ['Jan', 'Feb', 'Mar', 'Apr', 'Mei', 'Jun', 'Jul', 'Ago', 'Sep', 'Okt', 'Nov', 'Des'],
date: '%m/%d/%Y',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

East Africans use dd/mm/yyyy so %d/%m/%Y

@alexcjohnson
Copy link
Collaborator

Thanks @kndungu ! @booleanbetrayal if you can merge in @kndungu 's suggestions I'll be happy to merge 😄

@booleanbetrayal
Copy link
Contributor Author

Thanks @kndungu ! I've updated the PR with a follow-up commit @alexcjohnson .

@alexcjohnson alexcjohnson merged commit b89d101 into plotly:master Apr 27, 2018
@alexcjohnson alexcjohnson added this to the 1.37.0 milestone Apr 27, 2018
@alexcjohnson
Copy link
Collaborator

Thanks @booleanbetrayal - this will be in the 1.37.0 release, expected next week.

@booleanbetrayal booleanbetrayal deleted the patch-1 branch April 27, 2018 16:41
@booleanbetrayal
Copy link
Contributor Author

Great -- Thanks!

@kndungu
Copy link

kndungu commented Apr 30, 2018

🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants