-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(locale): add Swahili localization support #2526
Conversation
Thanks @booleanbetrayal ! Can I ask you though (as mentioned in the PR template) to update |
updated in a rebase @alexcjohnson |
Thanks - I just made a couple of changes to put the format on par with the others in |
The hover-tooltips and month / day names were professionally reviewed by a paid translation service back when we were doing our own localization implementation. The rest have been machine-translated. The Plotly.js locales were back-ported for consistency. I don't actually know of any Swahili speakers personally. How do you usually solicit for help for these things? |
Got it. The professionally reviewed ones should be great, and that set (dates & hover tips) covers arguably the most important ones. I'm a little uneasy with machine translation though, if it hasn't been reviewed by a human. Are you doing this for a customer who might be willing to help out? I can keep asking around but so far have not found any Swahili speakers in my own network. |
I wish I had access to some customers, but I don't. We're no longer targeting the market segment that brought us those speakers, but would like to continue supporting the locale, just in case. Trying to simplify our codebase and get us up to speed with Plotly.js localization support and this backfill makes life easier. I'd be happy to chip in a few bucks to help pay for a general professional translations services' pass, though. |
Good news! We've found a Swahili speaker - @kndungu has offered to review. 🎉 |
Awesome -- thanks @kndungu ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A pretty good job had already been done, made it that much easier.
lib/locales/sw.js
Outdated
name: 'sw', | ||
dictionary: { | ||
'Autoscale': 'Kigezo - otomatiki', | ||
'Box Select': 'Kuteua kisanduku', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The better translation would be Teua kisanduku
lib/locales/sw.js
Outdated
dictionary: { | ||
'Autoscale': 'Kigezo - otomatiki', | ||
'Box Select': 'Kuteua kisanduku', | ||
'Click to enter Colorscale title': 'Bonyeza kuingia kichwa cha Colorscale', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonyeza kuandika kichwa cha Colorscale
lib/locales/sw.js
Outdated
'Autoscale': 'Kigezo - otomatiki', | ||
'Box Select': 'Kuteua kisanduku', | ||
'Click to enter Colorscale title': 'Bonyeza kuingia kichwa cha Colorscale', | ||
'Click to enter Component A title': 'Bofya ili uingize kichwa cha A kichwa', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonyeza kuandika kichwa cha sehemu A
lib/locales/sw.js
Outdated
'Box Select': 'Kuteua kisanduku', | ||
'Click to enter Colorscale title': 'Bonyeza kuingia kichwa cha Colorscale', | ||
'Click to enter Component A title': 'Bofya ili uingize kichwa cha A kichwa', | ||
'Click to enter Component B title': 'Bofya ili uingize kichwa cha B kichwa', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonyeza kuandika kichwa cha sehemu B
lib/locales/sw.js
Outdated
'Click to enter Colorscale title': 'Bonyeza kuingia kichwa cha Colorscale', | ||
'Click to enter Component A title': 'Bofya ili uingize kichwa cha A kichwa', | ||
'Click to enter Component B title': 'Bofya ili uingize kichwa cha B kichwa', | ||
'Click to enter Component C title': 'Bofya ili uingize kichwa cha C kichwa', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonyeza kuandika kichwa cha sehemu C
lib/locales/sw.js
Outdated
'Lasso Select': 'Kuteua lasso', | ||
'Orbital rotation': 'Mzunguko wa mazao', | ||
'Pan': 'Tandaza', | ||
'Produced with Plotly': 'Iliyotokana na Plotly', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ilitengenezwa na Plotly
lib/locales/sw.js
Outdated
'Double-click to zoom back out': 'Bonyeza mara mbili ili uongeze tena', | ||
'Download plot as a png': 'Pakua mpango kama png', | ||
'Edit in Chart Studio': 'Badilisha katika Studio ya Chati', | ||
'IE only supports svg. Changing format to svg.': 'IE inasaidia tu svg. Kubadili muundo kwa svg.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IE inatumia tu svg. Tunabadilisha muundo kuwa svg.
lib/locales/sw.js
Outdated
'Double-click on legend to isolate one trace': 'Bonyeza mara mbili juu ya hadithi ili kutenganisha moja kwa moja', | ||
'Double-click to zoom back out': 'Bonyeza mara mbili ili uongeze tena', | ||
'Download plot as a png': 'Pakua mpango kama png', | ||
'Edit in Chart Studio': 'Badilisha katika Studio ya Chati', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hariri katika Chart studio
lib/locales/sw.js
Outdated
'Click to enter radial axis title': 'Bonyeza kuingia kichwa cha mhimili wa radial', | ||
'Compare data on hover': 'Linganisha data kielekezi kinapoelea', | ||
'Double-click on legend to isolate one trace': 'Bonyeza mara mbili juu ya hadithi ili kutenganisha moja kwa moja', | ||
'Double-click to zoom back out': 'Bonyeza mara mbili ili uongeze tena', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonyeza mara mbili ili kuvuta nje
lib/locales/sw.js
Outdated
shortDays: ['Sun', 'Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat'], | ||
months: ['Januari', 'Februari', 'Machi', 'Aprili', 'Mei', 'Juni', 'Julai', 'Agosti', 'Septemba', 'Oktoba', 'Novemba', 'Desemba'], | ||
shortMonths: ['Jan', 'Feb', 'Mar', 'Apr', 'Mei', 'Jun', 'Jul', 'Ago', 'Sep', 'Okt', 'Nov', 'Des'], | ||
date: '%m/%d/%Y', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
East Africans use dd/mm/yyyy
so %d/%m/%Y
Thanks @kndungu ! @booleanbetrayal if you can merge in @kndungu 's suggestions I'll be happy to merge 😄 |
Thanks @kndungu ! I've updated the PR with a follow-up commit @alexcjohnson . |
Thanks @booleanbetrayal - this will be in the 1.37.0 release, expected next week. |
Great -- Thanks! |
🎆 |
No description provided.