Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Czech localization #2483

Merged
merged 3 commits into from
Mar 27, 2018
Merged

Czech localization #2483

merged 3 commits into from
Mar 27, 2018

Conversation

fhurta
Copy link
Contributor

@fhurta fhurta commented Mar 20, 2018

Contains Czech localization.
(Unfotunatelly, I don't know other czech users of Plotly.js, so hopefully some find this and approve/make corrections.)

@etpinard etpinard changed the title type: translation Czech localization Mar 20, 2018
@etpinard
Copy link
Contributor

Thanks very much!

@alexcjohnson
Copy link
Collaborator

Thanks @fhurta ! I hope you don't mind that I asked a Slovak friend to review 🇨🇿 🇸🇰 - that's as close as I could get but he assures me he is qualified 😅 His comments:

I think it's good. I would only change "střední" to "průměr" (literally meaning Average), because "průměr" is a noun while "střední" is an adjective and if you needed a noun you'd need to say "střední hodnota" (=mean value).

What do you think, is that reasonable?

Also a couple of things I noticed:

  • There are two new strings that haven't made it into whichever file you based this off: "Click to enter radial axis title" and "new text" - can you add these?
  • "kde:" (kernel density estimate) - is that understandable as is, to Czech speakers who know what a violin plot is, or is there a reasonable (and compact) translation?

@fhurta
Copy link
Contributor Author

fhurta commented Mar 27, 2018

The comments look reasonable (as I only use scatter graph, I don't know the context how the titles are used exactly). I added the two missing items. Regarding the changes:

  • mean - is the context here average value or mean value? if noun is expected here then I would translate it to either průměr or střed or střední hodnota

  • kde - I googled it and haven't found any czech equivalent. I found some diploma thesis using this term, so I expect it is known term to violin plots users (or someone more familiar with it may suggest something).

@alexcjohnson
Copy link
Collaborator

OK great - thanks for adding the new ones. Lets leave kde as is. mean and mean ± σ are used in hover labels for box plots, depending on the information shown:
screen shot 2018-03-27 at 8 02 40 am
screen shot 2018-03-27 at 8 02 18 am
Your call whether an adjective or a noun makes most sense here, but since it's in a hover label it's preferable to keep it short.

@fhurta
Copy link
Contributor Author

fhurta commented Mar 27, 2018

OK then. Seems 'průměr' fits the best here. Updated.

@alexcjohnson
Copy link
Collaborator

Thanks for the quick updates, I think it's ready now!

@alexcjohnson alexcjohnson merged commit c385218 into plotly:master Mar 27, 2018
@etpinard etpinard added this to the v1.36.0 milestone Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants