Replace docstring \r\n with \n when generating classes from windows.

[T4rk1n]

Resolves #366

[rmarren1]

Would just changing this part work?

dash/dash/development/base_component.py

Lines 489 to 495 in 1469268

	return (
	"""A {name} component.\n{description}
	Keyword arguments:\n{args}
	Available events: {events}"""
	).format(

I think git will auto-magically put \r\n instead of \n in this code block, which we can avoid by explicitly putting \n
e.g. return ("A {name} component.\n{description}\n\nKeyword arguments:\n{args}\n\nAvailable events: {events}").format(...)

[T4rk1n]

No it wouldn't work, it's not those that are explicit the problems (\n), it's the whitespace newlines that get auto \r\n by python not git. By replacing the output of the docstring, we can keep a sane docstring.

[rmarren1]

Okay that makes sense, didn't know python was the one doing that.

[rmarren1]

💃

Do we also need to do that replacement here?

dash/dash/development/base_component.py

Lines 271 to 352 in 1469268

	"""
	Dynamically generate class strings to have nicely formatted docstrings,
	keyword arguments, and repr
	Inspired by http://jameso.be/2013/08/06/namedtuple.html
	Parameters
	----------
	typename
	props
	description
	namespace
	Returns
	-------
	string
	"""
	# TODO _prop_names, _type, _namespace, available_events,
	# and available_properties
	# can be modified by a Dash JS developer via setattr
	# TODO - Tab out the repr for the repr of these components to make it
	# look more like a hierarchical tree
	# TODO - Include "description" "defaultValue" in the repr and docstring
	#
	# TODO - Handle "required"
	#
	# TODO - How to handle user-given `null` values? I want to include
	# an expanded docstring like Dropdown(value=None, id=None)
	# but by templating in those None values, I have no way of knowing
	# whether a property is None because the user explicitly wanted
	# it to be `null` or whether that was just the default value.
	# The solution might be to deal with default values better although
	# not all component authors will supply those.
	c = '''class {typename}(Component):
	"""{docstring}"""
	@_explicitize_args
	def __init__(self, {default_argtext}):
	self._prop_names = {list_of_valid_keys}
	self._type = '{typename}'
	self._namespace = '{namespace}'
	self._valid_wildcard_attributes =\
	{list_of_valid_wildcard_attr_prefixes}
	self.available_events = {events}
	self.available_properties = {list_of_valid_keys}
	self.available_wildcard_properties =\
	{list_of_valid_wildcard_attr_prefixes}
	_explicit_args = kwargs.pop('_explicit_args')
	_locals = locals()
	_locals.update(kwargs) # For wildcard attrs
	args = {{k: _locals[k] for k in _explicit_args if k != 'children'}}
	for k in {required_args}:
	if k not in args:
	raise TypeError(
	'Required argument `' + k + '` was not specified.')
	super({typename}, self).__init__({argtext})
	def __repr__(self):
	if(any(getattr(self, c, None) is not None
	for c in self._prop_names
	if c is not self._prop_names[0])
	or any(getattr(self, c, None) is not None
	for c in self.__dict__.keys()
	if any(c.startswith(wc_attr)
	for wc_attr in self._valid_wildcard_attributes))):
	props_string = ', '.join([c+'='+repr(getattr(self, c, None))
	for c in self._prop_names
	if getattr(self, c, None) is not None])
	wilds_string = ', '.join([c+'='+repr(getattr(self, c, None))
	for c in self.__dict__.keys()
	if any([c.startswith(wc_attr)
	for wc_attr in
	self._valid_wildcard_attributes])])
	return ('{typename}(' + props_string +
	(', ' + wilds_string if wilds_string != '' else '') + ')')
	else:
	return (
	'{typename}(' +
	repr(getattr(self, self._prop_names[0], None)) + ')')
	'''

[T4rk1n]

No, I tested it and it works with just that change.