Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate class endlines. #366

Closed
T4rk1n opened this issue Sep 4, 2018 · 2 comments
Closed

Generate class endlines. #366

T4rk1n opened this issue Sep 4, 2018 · 2 comments
Assignees

Comments

@T4rk1n
Copy link
Contributor

T4rk1n commented Sep 4, 2018

When generating classes for the components libs, if you are on windows, the endlines of the docstring will be \r\n instead of \n. This gives ^m diff on github when there shouldn't be a difference.

@rmarren1
Copy link
Contributor

rmarren1 commented Sep 4, 2018

I think we should just add * text=auto to .gitattributes to the boilerplate since we want all our component repos to be cross platform. https://stackoverflow.com/a/21473084/8807960

I'll see if I can test this by putting some ^m in a class file, but I don't have a real windows environment to test on

@T4rk1n
Copy link
Contributor Author

T4rk1n commented Sep 4, 2018

@rmarren1 I'll try it from my machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants