Issue 745 - Rename async modules #762
Conversation
| 'external_url': ( | ||
| 'https://unpkg.com/dash-core-components@{}' | ||
| '/dash_core_components/async~graph~plotlyjs.js' | ||
| '/dash_core_components/async-plotlyjs.js' |
There was a problem hiding this comment.
Pretty bad error here and below with serve_locally=False
There was a problem hiding this comment.
Yikes, nice find! Is there anything we can do to test this? I'm thinking like a standard test we can put in dash.testing and then run in all our repos with appropriate parameters, looping over _js_dist and ensuring external_url matches a certain pattern vs relative_package_path?
There was a problem hiding this comment.
a followup issue would be fine for now.
There was a problem hiding this comment.
Follow up in https://github.com/plotly/dash-core/issues/171 - providing at least two approaches: pattern matching as suggested and something more robust / matching e2e usage but requiring more effort.
|
Team, Thank you for changing the ~ to a -. The use @ sign in the URLS is may also not be considered safe and be blocked. Would it be possible to alter that too? 'external_url': ( |
That's just the way https://unpkg.com/ works, we have no control over that. But your app will only access those URLs if you explicitly set |
Closes #745