Issue 745 - Rename async modules (#762)

plotly · Feb 27, 2020 · 8bb6a58 · 8bb6a58
1 parent 627fc0f
commit 8bb6a58
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 13 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,10 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [Unreleased]
+### Changed
+- [#762](https://github.com/plotly/dash-core-components/pull/762) Renamed async modules with hyphen `-` instead of tilde `~`
+
 ## [1.8.0] - 2020-02-04
 ### Changed
 - [#743](https://github.com/plotly/dash-core-components/pull/743) Location component now emits an event on URL path update from Link component

diff --git a/MANIFEST.in b/MANIFEST.in
@@ -2,8 +2,8 @@ include dash_core_components/dash_core_components.min.js
 include dash_core_components/dash_core_components.min.js.map
 include dash_core_components/dash_core_components-shared.js
 include dash_core_components/dash_core_components-shared.js.map
-include dash_core_components/async~*.js
-include dash_core_components/async~*.js.map
+include dash_core_components/async-*.js
+include dash_core_components/async-*.js.map
 include dash_core_components/metadata.json
 include dash_core_components/package-info.json
 include dash_core_components/plotly.min.js

diff --git a/dash_core_components_base/__init__.py b/dash_core_components_base/__init__.py
@@ -52,20 +52,20 @@
 _js_dist = []
 
 _js_dist.extend([{
-        'relative_package_path': 'async~{}.js'.format(async_resource),
+        'relative_package_path': 'async-{}.js'.format(async_resource),
         'external_url': (
             'https://unpkg.com/dash-core-components@{}'
-            '/dash_core_components/async~{}.js'
+            '/dash_core_components/async-{}.js'
         ).format(__version__, async_resource),
         'namespace': 'dash_core_components',
         'async': True
     } for async_resource in async_resources])
 
 _js_dist.extend([{
-        'relative_package_path': 'async~{}.js.map'.format(async_resource),
+        'relative_package_path': 'async-{}.js.map'.format(async_resource),
         'external_url': (
             'https://unpkg.com/dash-core-components@{}'
-            '/dash_core_components/async~{}.js.map'
+            '/dash_core_components/async-{}.js.map'
         ).format(__version__, async_resource),
         'namespace': 'dash_core_components',
         'dynamic': True
@@ -116,19 +116,19 @@
         'async': 'eager'
     },
     {
-        'relative_package_path': 'async~plotlyjs.js',
+        'relative_package_path': 'async-plotlyjs.js',
         'external_url': (
             'https://unpkg.com/dash-core-components@{}'
-            '/dash_core_components/async~graph~plotlyjs.js'
+            '/dash_core_components/async-plotlyjs.js'
         ).format(__version__),
         'namespace': 'dash_core_components',
         'async': 'lazy'
     },
     {
-        'relative_package_path': 'async~plotlyjs.js.map',
+        'relative_package_path': 'async-plotlyjs.js.map',
         'external_url': (
             'https://unpkg.com/dash-core-components@{}'
-            '/dash_core_components/async~graph~plotlyjs.js.map'
+            '/dash_core_components/async-plotlyjs.js.map'
         ).format(__version__),
         'namespace': 'dash_core_components',
         'dynamic': True

diff --git a/tests/integration/graph/test_graph_varia.py b/tests/integration/graph/test_graph_varia.py
@@ -25,7 +25,7 @@ def findSyncPlotlyJs(scripts):
 
 def findAsyncPlotlyJs(scripts):
     for script in scripts:
-        if "dash_core_components/async~plotlyjs" in script.get_attribute(
+        if "dash_core_components/async-plotlyjs" in script.get_attribute(
             'src'
         ):
             return script

diff --git a/webpack.config.js b/webpack.config.js
@@ -118,7 +118,7 @@ module.exports = (env, argv) => {
                         chunks: 'async',
                         minSize: 0,
                         name(module, chunks, cacheGroupKey) {
-                            return `${cacheGroupKey}~${chunks[0].name}`;
+                            return `${cacheGroupKey}-${chunks[0].name}`;
                         }
                     },
                     shared: {
@@ -134,7 +134,7 @@ module.exports = (env, argv) => {
             new WebpackDashDynamicImport(),
             new webpack.SourceMapDevToolPlugin({
                 filename: '[file].map',
-                exclude: ['async~plotlyjs']
+                exclude: ['async-plotlyjs']
             })
         ]
     }