Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade pd client to make sure tso client initiate successfully (#58752) #58804

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #58752

What problem does this PR solve?

Issue Number: close #55248, close #58239

ref tikv/pd#8962

Problem Summary: tso client may initiate failed

What changed and how does it work?

retry it, and if it always fails after retry, it will report an error.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the problem of importing data or adding indexes may fail when PD encounter network problems.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Jan 8, 2025
Signed-off-by: okJiang <819421878@qq.com>
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 25, 2025
Signed-off-by: okJiang <819421878@qq.com>
@okJiang
Copy link
Member

okJiang commented Feb 25, 2025

/retest

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.5@263e7b7). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #58804   +/-   ##
================================================
  Coverage               ?   72.1782%           
================================================
  Files                  ?       1417           
  Lines                  ?     413817           
  Branches               ?          0           
================================================
  Hits                   ?     298686           
  Misses                 ?      95119           
  Partials               ?      20012           
Flag Coverage Δ
unit 72.1782% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.4763% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 25, 2025
Copy link

ti-chi-bot bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 25, 2025
Copy link

ti-chi-bot bot commented Feb 25, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-25 08:42:48.867753161 +0000 UTC m=+345316.820911420: ☑️ agreed by okJiang.
  • 2025-02-25 09:28:42.803539767 +0000 UTC m=+348070.756698033: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit 2934832 into pingcap:release-7.5 Feb 25, 2025
18 checks passed
@okJiang okJiang deleted the cherry-pick-58752-to-release-7.5 branch February 25, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants