Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br restore doesn't tolerate error "[PD:client:ErrClientGetTSO]get TSO failed, tso client is nil" #58239

Closed
fubinzh opened this issue Dec 13, 2024 · 2 comments · Fixed by #58752
Closed

br restore doesn't tolerate error "[PD:client:ErrClientGetTSO]get TSO failed, tso client is nil" #58239

fubinzh opened this issue Dec 13, 2024 · 2 comments · Fixed by #58752
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@fubinzh
Copy link

fubinzh commented Dec 13, 2024

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. run br restore, there is a tmp error resulting in tso client not created successfully.

2. What did you expect to see? (Required)

br restore should be able to tolerate tmp error like this.

3. What did you see instead (Required)

br restore doesn't tolerate the tmp error
Image

4. What is your TiDB version? (Required)

v8.5.0
@fubinzh fubinzh added the type/bug The issue is confirmed as a bug. label Dec 13, 2024
@fubinzh
Copy link
Author

fubinzh commented Dec 13, 2024

/component br

@ti-chi-bot ti-chi-bot bot added the component/br This issue is related to BR of TiDB. label Dec 13, 2024
@lance6716
Copy link
Contributor

please help push PD side to fix this error completely

tikv/pd#8630

@okJiang okJiang mentioned this issue Dec 31, 2024
Closed
@okJiang okJiang mentioned this issue Jan 7, 2025
Merged
13 tasks
@okJiang okJiang added affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. and removed may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 may-affects-8.1 may-affects-8.5 labels Jan 7, 2025
@ti-chi-bot ti-chi-bot bot closed this as completed in 510d003 Jan 8, 2025
This was referenced Jan 8, 2025
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Feb 25, 2025
@ti-chi-bot
*: upgrade pd client to make sure tso client initiate successfully (#…
2934832 
…58752) (#58804)

close #55248, close #58239
ti-chi-bot bot pushed a commit that referenced this issue Feb 25, 2025
@ti-chi-bot
*: upgrade pd client to make sure tso client initiate successfully (#…
8872106 
…58752) (#58802)

close #55248, close #58239
ti-chi-bot bot pushed a commit that referenced this issue Feb 25, 2025
@ti-chi-bot
*: upgrade pd client to make sure tso client initiate successfully (#…
950ea34 
…58752) (#58803)

close #55248, close #58239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. component/br This issue is related to BR of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: upgrade pd client to make sure tso client initiate successfully okJiang/tidb
4 participants
@lance6716 @jebter @fubinzh @okJiang