Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated hello-pinecone-aws document #415

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Conversation

Joshua-Briggs
Copy link
Collaborator

Problem

Updated document
Describe the purpose of this change. What problem is being solved and why?
Up-to-date with jhamon's feedback

Solution

added param names, changed the nbviewer link, changed if statement, deleted sleep function, made spec within create index method alongside AwsRegion and Metric enums.
Describe the approach you took. Link to any relevant bugs, issues, docs, or other resources.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.
Ran within local notebook, need to check on colab too

@Joshua-Briggs Joshua-Briggs self-assigned this Mar 4, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jamescalam jamescalam changed the title updated hello-pinecone-aws document fix: updated hello-pinecone-aws document Mar 4, 2025
Copy link
Collaborator

@jamescalam jamescalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these all seem resolved @jhamon

I made a small tweak to use getpass to pull in the pinecone api key and confirmed everything runs as expected in colab

Copy link
Collaborator

@jhamon jhamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@jamescalam jamescalam merged commit e60056b into master Mar 4, 2025
7 checks passed
@jamescalam jamescalam deleted the josh/aws-update branch March 4, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants