-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated hello-pinecone-aws example to use pinecone-client==6.0.1 #412
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me, tagging @jhamon for PC review
@jhamon you can run in colab https://colab.research.google.com/github/Joshua-Briggs/examples/blob/master/learn/search/semantic-search/hello-pinecone-aws.ipynb -- just reqs an api key near the start
Overall this seems fine to merge. The test run is failing, I think, because the Besides the updates you've made, I'm trying to make the following changes whenever I see an opportunity:
|
we'll make these changes @jhamon |
Problem
The current notebook
hello-pinecone-aws.ipynb
uses pinecone-client==3.0.5 which is outdated and therefore some functions needed updating alongside the notebook.Solution
Updated the notebook to use pinecone-client==6.0.1 and amended functions to use up-to-date parameters, such as:
index_name
parameter toname
in theIndex
method.spec
parameter to thecreate_index
method.Type of Change
Test Plan
A quick run through the notebook to check it runs as intended.