dex: faillible dex execution #2740

erwanor · 2023-06-26T20:27:57Z

Part of #2589, this PR:

makes internal dex operations faillible i.e. catching overflow failures
specifies and implement gracefully recovery from those errors
Restructure DEX computations to not be wide #2644

erwanor · 2023-07-11T17:52:25Z

Merging this optimistically, along with #2805. I'm going to run a devnet running this version and do a round of assurance on it.

erwanor had a problem deploying to smoke-test June 26, 2023 20:28 — with GitHub Actions Failure

erwanor had a problem deploying to smoke-test July 9, 2023 16:17 — with GitHub Actions Failure

erwanor force-pushed the faillible_dex_engine branch from d589573 to 4b71541 Compare July 9, 2023 16:27

erwanor had a problem deploying to smoke-test July 9, 2023 16:27 — with GitHub Actions Failure

erwanor had a problem deploying to smoke-test July 9, 2023 19:07 — with GitHub Actions Error

erwanor had a problem deploying to smoke-test July 9, 2023 19:21 — with GitHub Actions Failure

erwanor had a problem deploying to smoke-test July 9, 2023 20:21 — with GitHub Actions Failure

erwanor had a problem deploying to smoke-test July 10, 2023 12:40 — with GitHub Actions Failure

erwanor mentioned this pull request Jul 10, 2023

Restore support for ETH assets #2677

Closed

erwanor force-pushed the faillible_dex_engine branch from bd0b568 to 6950648 Compare July 10, 2023 14:09

erwanor had a problem deploying to smoke-test July 10, 2023 14:09 — with GitHub Actions Failure

erwanor had a problem deploying to smoke-test July 10, 2023 15:21 — with GitHub Actions Failure

erwanor force-pushed the faillible_dex_engine branch from b0600b3 to 9d985b1 Compare July 10, 2023 16:13

erwanor had a problem deploying to smoke-test July 10, 2023 16:13 — with GitHub Actions Failure

erwanor had a problem deploying to smoke-test July 10, 2023 17:20 — with GitHub Actions Failure

erwanor force-pushed the faillible_dex_engine branch from dd384d5 to e607e76 Compare July 10, 2023 17:58

erwanor had a problem deploying to smoke-test July 10, 2023 17:58 — with GitHub Actions Failure

erwanor force-pushed the faillible_dex_engine branch from e607e76 to e6e9847 Compare July 10, 2023 18:20

erwanor had a problem deploying to smoke-test July 10, 2023 18:20 — with GitHub Actions Failure

erwanor force-pushed the faillible_dex_engine branch from e6e9847 to 51bc97f Compare July 10, 2023 18:49

erwanor had a problem deploying to smoke-test July 10, 2023 18:49 — with GitHub Actions Failure

erwanor force-pushed the faillible_dex_engine branch from 51bc97f to b2ce773 Compare July 10, 2023 19:10

erwanor had a problem deploying to smoke-test July 10, 2023 19:10 — with GitHub Actions Failure

erwanor force-pushed the faillible_dex_engine branch from b2ce773 to ef3f71d Compare July 10, 2023 19:44

erwanor had a problem deploying to smoke-test July 10, 2023 19:44 — with GitHub Actions Failure

erwanor force-pushed the faillible_dex_engine branch from ef3f71d to 84f1496 Compare July 10, 2023 20:09

erwanor had a problem deploying to smoke-test July 10, 2023 20:10 — with GitHub Actions Failure

erwanor force-pushed the faillible_dex_engine branch from 84f1496 to b1d7b3f Compare July 10, 2023 20:32

erwanor had a problem deploying to smoke-test July 10, 2023 20:32 — with GitHub Actions Failure

erwanor temporarily deployed to smoke-test July 10, 2023 21:04 — with GitHub Actions Inactive

erwanor marked this pull request as ready for review July 11, 2023 15:00

erwanor had a problem deploying to smoke-test July 11, 2023 15:00 — with GitHub Actions Error

erwanor added 19 commits July 11, 2023 12:03

dex(router): use correct nomenclature in comments

3a17e29

dex(phi): make convert_to routines faillible

3f99581

dex(router): make fill_* methods faillible

7a31045

dex(router): make trading function tests use the new api

3e297e8

dex(router): use BTreeMap to record positions

588612d

dex(lp): check input asset id match trading pair

158789a

dex(router): surface overflows during constraint detection

e4b1ede

dex(router): use FillError in routing execution

a99769e

dex: add thiserror to deps

e9c32b3

dex(router): recover from errors during routing execution

ca26e01

dex(router): tentatively crash on I/O errors

529848c

dex(router): compute price ratios first

779c61c

dex(router): use correct predicate in asset id check

d502707

dex: adjust tests to new rounding expectations

45348c2

dex: remove nft integration test + adjust values

0f0e1c4

tests(integration): stop testing swaps with NFTs

86cf679

dex(tests): issue close-all from correct address

88703ed

dex(router): bail on typical FillErrors

b15468a

dex(router): edit expect statements

8f1dd90

erwanor force-pushed the faillible_dex_engine branch from 8716802 to 8f1dd90 Compare July 11, 2023 16:03

erwanor temporarily deployed to smoke-test July 11, 2023 16:03 — with GitHub Actions Inactive

erwanor merged commit 03f0235 into main Jul 11, 2023

erwanor deleted the faillible_dex_engine branch July 11, 2023 17:52

erwanor mentioned this pull request Jul 11, 2023

Restructure DEX computations to not be wide #2644

Closed

cratelyn added the A-dex Area: Relates to the dex label Mar 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dex: faillible dex execution #2740

dex: faillible dex execution #2740

erwanor commented Jun 26, 2023 •

edited

Loading

erwanor commented Jul 11, 2023 •

edited

Loading

dex: faillible dex execution #2740

dex: faillible dex execution #2740

Conversation

erwanor commented Jun 26, 2023 • edited Loading

erwanor commented Jul 11, 2023 • edited Loading

erwanor commented Jun 26, 2023 •

edited

Loading

erwanor commented Jul 11, 2023 •

edited

Loading