-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore support for ETH assets #2677
Comments
@erwanor Thoughts on inclusion in 55? I see there's some other high-priority DEX work still in flight. Please provide an update async when you can. |
Moving this to 57, because although this is a small change in terms of LoC, it will require more thorough quality assurance work than time allows for now. In particular, we want to test that error recovery implemented in #2740 works well in the case of complex multi-hop routes. This requires somewhat involved assurance work which I hadn't fully realized during planning. |
After this is complete we should also (in a separate issue) re-enable ETH in Osiris and allocate some ETH to the Osiris wallet. |
Is your feature request related to a problem? Please describe.$2^{60}$ bits wide. So that $k = p R_1 + q R_2$ is at most $\log_2(2*(2^{60} -1)^2) = 121$ bits fitting in a $128$ bits with some headroom.
We uncovered a fixpoint bug (#2559) which we temporarily routed around by temporarily limiting DEX values to be at most
Describe the solution you'd like
The above solution works as a temporary bandaid, but limits our ability to support assets with larger denom units such as ETH and ERC-20s, which we definitely want to be supporting. Instead of limiting values, we should incorporate finding a working solution as part of #2589.
The text was updated successfully, but these errors were encountered: