Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rtl872x] hal: implement i2c sleep and fix the reset APIs #2497

Merged
merged 7 commits into from
Aug 15, 2022
Merged

Conversation

XuGuohui
Copy link
Member

@XuGuohui XuGuohui commented Aug 3, 2022

Problem

The no_fixture I2C test fails on the TrackerM platform

Solution

  1. Implement the I2C HAL sleep API
  2. Fix the I2C reset API

Steps to Test

Build and run the user/tests/wiring/no_fixture app.

References

sc-106750


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@XuGuohui XuGuohui requested review from avtolstoy and keeramis August 3, 2022 05:32
@XuGuohui
Copy link
Member Author

XuGuohui commented Aug 3, 2022

The fix to I2C reset function should be applied to other Gen3 platforms as well, but we're not running into I2C issues on those platforms so far, so I leave them as-is for now.

@XuGuohui XuGuohui requested a review from avtolstoy August 3, 2022 14:51
@XuGuohui XuGuohui requested a review from avtolstoy August 15, 2022 06:35
@XuGuohui XuGuohui merged commit fc3053b into develop Aug 15, 2022
@XuGuohui XuGuohui deleted the fix/p2_i2c branch August 15, 2022 09:31
@technobly technobly added the bug label Aug 15, 2022
@technobly technobly added this to the 5.0.0 milestone Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants