[rtl872x] hal: resolve review comments.

Author: XuGuohui

hal/src/rtl872x/gpio_hal.cpp

@@ -184,6 +184,10 @@ int hal_gpio_configure(hal_pin_t pin, const hal_gpio_config_t* conf, void* reser
             }
         }
 
+        if ((mode == OUTPUT_OPEN_DRAIN || mode == OUTPUT_OPEN_DRAIN_PULLUP) && conf->set_value && conf->value == 0) {
+            GPIO_InitStruct.GPIO_Mode = GPIO_Mode_OUT;
+        }
+
         GPIO_Init(&GPIO_InitStruct);
         pinInfo->pin_mode = mode;
 

hal/src/rtl872x/i2c_hal.cpp

@@ -200,7 +200,7 @@ class I2cClass {
         return begin((i2cInitStruct_.I2CMaster == I2C_MASTER_MODE) ? I2C_MODE_MASTER : I2C_MODE_SLAVE, i2cInitStruct_.I2CAckAddr);
     }
 
-    void reset() {
+    uint8_t reset() {
         end();
 
         // Just in case make sure that the pins are correctly configured (they should anyway be at this point)
@@ -214,9 +214,8 @@ class I2cClass {
         hal_gpio_configure(sdaPin_, &conf, nullptr);
 
         // Check if slave is stretching the SCL
-        if (!WAIT_TIMED(transConfig_.timeout_ms, hal_gpio_read(sclPin_) == 0)) {
-            // We can't proceed because there is probably hardware issue.
-            SPARK_ASSERT(false);
+        if (!WAIT_TIMED(HAL_I2C_DEFAULT_TIMEOUT_MS, hal_gpio_read(sclPin_) == 0)) {
+            return 1;
         }
 
         // Generate up to 9 pulses on SCL to tell slave to release the bus
@@ -246,6 +245,7 @@ class I2cClass {
 
         hal_i2c_mode_t mode = (i2cInitStruct_.I2CMaster  == I2C_MASTER_MODE) ? I2C_MODE_MASTER : I2C_MODE_SLAVE;
         begin(mode, i2cInitStruct_.I2CAckAddr);
+        return !isEnabled(); // 0 for success, to be consistent with other Gen3 platforms
     }
 
     int setSpeed(uint32_t speed) {
@@ -733,8 +733,7 @@ void hal_i2c_enable_dma_mode(hal_i2c_interface_t i2c, bool enable, void* reserve
 uint8_t hal_i2c_reset(hal_i2c_interface_t i2c, uint32_t reserved, void* reserved1) {
     auto instance = CHECK_TRUE_RETURN(I2cClass::getInstance(i2c), 1);
     I2cLock lk(instance);
-    instance->reset();
-    return 0;
+    return instance->reset();
 }
 
 int32_t hal_i2c_lock(hal_i2c_interface_t i2c, void* reserved) {