[tests] Fix broken tone and servo tests for p2 platform #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-brust
force-pushed
the
fix/p2-servo-tone
branch
from
618c4b9 to
440700a
Compare
avtolstoy
approved these changes
Jul 13, 2022
scott-brust
force-pushed
the
fix/p2-servo-tone
branch
from
8892ec2 to
3fae3a9
Compare
technobly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
5.0.0-alpha.1 tests showed tone and servo tests failing on P2. The failures are due to errors introduced when rebasing changes for esomx support.
Solution
Fix the rebase/merge errors for P2 platform
Steps to Test
Re run
no_fixture_long_runningtests for both P2 and esomx platformsExample App
use
no_fixture_long_runningReferences
Completeness