Fix broken tone and servo tests for p2 platform

Author: scott-brust

user/tests/wiring/no_fixture_long_running/servo.cpp

@@ -28,10 +28,10 @@
 #include "unit-test/unit-test.h"
 
 #if HAL_PLATFORM_GEN == 3
-#if PLATFORM_ID == PLATFORM_ESOMX
-static const pin_t pin = D0, pin2 = D1;
+#if PLATFORM_ID == PLATFORM_P2 || PLATFORM_ID == PLATFORM_ESOMX
+static const hal_pin_t pin = D1, pin2 = D8;
 #else
-static const pin_t pin = A0, pin2 = A1;
+static const hal_pin_t pin = A0, pin2 = A1;
 #endif
 #else
 #error "Unsupported platform"
@@ -40,9 +40,9 @@ static const pin_t pin = A0, pin2 = A1;
 test(SERVO_01_CannotAttachWhenPinSelectedIsNotTimerChannel) {
 #if HAL_PLATFORM_NRF52840
 # if PLATFORM_ID == PLATFORM_TRACKER
-    pin_t pin = BTN;
+    hal_pin_t pin = BTN;
 #elif PLATFORM_ID == PLATFORM_ESOMX
-    pin_t pin = A0;
+    hal_pin_t pin = A0;
 # else
     hal_pin_t pin = D0;
 # endif

user/tests/wiring/no_fixture_long_running/tone.cpp

@@ -27,18 +27,20 @@
 #include "tone_hal.h"
 #include "unit-test/unit-test.h"
 
-#if PLATFORM_ID == PLATFORM_ESOMX
-static const pin_t pin = D1;//pin under test
+#if PLATFORM_ID == PLATFORM_P2
+static const hal_pin_t pin = D1;//pin under test
+#elif PLATFORM_ID == PLATFORM_ESOMX
+static const hal_pin_t pin = A3;//pin under test
 #else
-static const pin_t pin = A1;//pin under test
+static const hal_pin_t pin = A1;//pin under test
 #endif
 
 test(TONE_01_NoGenerateWhenPinSelectedIsNotTimerChannel) {
 #if HAL_PLATFORM_NRF52840
 # if PLATFORM_ID == PLATFORM_TRACKER
-    pin_t pin = BTN;
+    hal_pin_t pin = BTN;
 # elif PLATFORM_ID == PLATFORM_ESOMX
-    pin_t pin = A0;
+    hal_pin_t pin = A0;
 # else
     hal_pin_t pin = D0;
 # endif