Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2503] Backport #7492 (manually) #7774

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Mar 3, 2025

Backport #7492 into stable2503 from bkontur.

Manual backport, because A4-needs-backport bot failed for some permission reasons of touched CI files in the original PR: #7492 (comment)

Closes: #7272
Relates to: #6578
Relates to: #7274

The PR enhances the `pallet-bridge-rewards` by making it generic over
the `RewardKind` type (previously hardcoded as `RewardsAccountParams`).
This modification allows the pallet to support multiple reward types
(e.g., P/K bridge, Snowbridge), increasing its flexibility and
applicability across various bridge scenarios.

Other pallets can register rewards using `bp_relayers::RewardLedger`,
which is implemented by the rewards pallet. The runtime can then be
configured with different mechanisms for paying/claiming rewards via
`bp_relayers::PaymentProcedure` (e.g., see the `pub struct
BridgeRewardPayer;` implementation for BridgeHubWestend).

The removed balances/rewards statistics from the complex relay (no
longer used) will eventually be reintroduced or fixed in the standalone
relayers via
paritytech/parity-bridges-common#3004 (comment).

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com>
Co-authored-by: Serban Iorga <serban@parity.io>
@bkontur bkontur requested review from a team as code owners March 3, 2025 10:45
@paritytech-review-bot paritytech-review-bot bot requested a review from a team March 3, 2025 10:46
@bkontur bkontur added the A3-backport Pull request is already reviewed well in another branch. label Mar 3, 2025
Copy link
Contributor

github-actions bot commented Mar 3, 2025

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/13629025228
Failed job name: check-runtime-migration

@bkontur bkontur enabled auto-merge (squash) March 3, 2025 11:11
@EgorPopelyaev EgorPopelyaev disabled auto-merge March 3, 2025 11:56
@EgorPopelyaev EgorPopelyaev merged commit 30298fd into stable2503 Mar 3, 2025
248 of 269 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-7492-to-stable2503-manually branch March 3, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants