Make pallet-bridge-rewards generic over RewardKind
#7492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cmd fmt |
|
/cmd fmt |
4 tasks
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
/cmd fmt |
franciscoaguirre
approved these changes
Feb 18, 2025
EgorPopelyaev
approved these changes
Feb 18, 2025
raymondkfcheung
approved these changes
Feb 18, 2025
Merged
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Serban Iorga <serban@parity.io>
bkontur
added
the
A4-needs-backport
|
Git push to origin failed for stable2407 with exitcode 1 |
|
Git push to origin failed for stable2409 with exitcode 1 |
|
Git push to origin failed for stable2412 with exitcode 1 |
|
Git push to origin failed for stable2503 with exitcode 1 |
bkontur
added a commit
that referenced
this pull request
Mar 3, 2025
Closes: #7272 Relates to: #6578 Relates to: #7274 The PR enhances the `pallet-bridge-rewards` by making it generic over the `RewardKind` type (previously hardcoded as `RewardsAccountParams`). This modification allows the pallet to support multiple reward types (e.g., P/K bridge, Snowbridge), increasing its flexibility and applicability across various bridge scenarios. Other pallets can register rewards using `bp_relayers::RewardLedger`, which is implemented by the rewards pallet. The runtime can then be configured with different mechanisms for paying/claiming rewards via `bp_relayers::PaymentProcedure` (e.g., see the `pub struct BridgeRewardPayer;` implementation for BridgeHubWestend). The removed balances/rewards statistics from the complex relay (no longer used) will eventually be reintroduced or fixed in the standalone relayers via paritytech/parity-bridges-common#3004 (comment). --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Serban Iorga <serban@parity.io>
EgorPopelyaev
pushed a commit
that referenced
this pull request
Mar 3, 2025
Backport #7492 into `stable2503` from bkontur. Manual backport, because `A4-needs-backport` bot failed for some permission reasons of touched CI files in the original PR: #7492 (comment) Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Francisco Aguirre <franciscoaguirreperez@gmail.com> Co-authored-by: Serban Iorga <serban@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7272
Relates to: #6578
Relates to: #7274
Description
The PR enhances the
pallet-bridge-rewardsby making it generic over theRewardKindtype (previously hardcoded asRewardsAccountParams). This modification allows the pallet to support multiple reward types (e.g., P/K bridge, Snowbridge), increasing its flexibility and applicability across various bridge scenarios.Other pallets can register rewards using
bp_relayers::RewardLedger, which is implemented by the rewards pallet. The runtime can then be configured with different mechanisms for paying/claiming rewards viabp_relayers::PaymentProcedure(e.g., see thepub struct BridgeRewardPayer;implementation for BridgeHubWestend).Follow-up
The removed balances/rewards statistics from the complex relay (no longer used) will eventually be reintroduced or fixed in the standalone relayers via paritytech/parity-bridges-common#3004 (comment).