fix(linter): support nested extending #9472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
This was referenced Mar 1, 2025
CodSpeed Performance ReportMerging #9472 will not alter performanceComparing Summary
|
camchenry
force-pushed
the
03-01-fix_linter_support_nested_extending
branch
from
1dc2156 to
d83d6c5
Compare
camchenry
force-pushed
the
02-23-feat_linter_inherit_rules_via_the_extended_config_files
branch
from
dd36f3c to
4cfdc59
Compare
camchenry
force-pushed
the
03-01-fix_linter_support_nested_extending
branch
from
d83d6c5 to
edc1d63
Compare
This was referenced Mar 1, 2025
camchenry
force-pushed
the
03-01-fix_linter_support_nested_extending
branch
from
edc1d63 to
2fc1e32
Compare
shulaoda
reviewed
Mar 2, 2025
shulaoda
approved these changes
Mar 2, 2025
Sysix
reviewed
Mar 2, 2025
camchenry
force-pushed
the
02-23-feat_linter_inherit_rules_via_the_extended_config_files
branch
from
4cfdc59 to
63b413f
Compare
camchenry
force-pushed
the
03-01-fix_linter_support_nested_extending
branch
from
2fc1e32 to
606233c
Compare
Sysix
approved these changes
Mar 3, 2025
Merge activity
|
camchenry
changed the base branch from
02-23-feat_linter_inherit_rules_via_the_extended_config_files
to
graphite-base/9472
camchenry
force-pushed
the
03-01-fix_linter_support_nested_extending
branch
from
606233c to
3d787c0
Compare
- part of #9307 Allows for using the `extends` keyword to chain multiple extended config files together: for example, a package config that extends a base config that extends a config from `node_modules` and so on. I don't really love what we're having to do here with using both `override_rules` and `ConfigStoreBuilder.with_rule`. I think there is a refactoring opportunity to merge some functionality together here, but I don't want to refactor and optimize before we have a more comprehensive test suite.
graphite-app
bot
force-pushed
the
03-01-fix_linter_support_nested_extending
branch
from
3d787c0 to
5ecda01
Compare
Boshen
added a commit
that referenced
this pull request
Mar 11, 2025
## [0.15.14] - 2025-03-11 ### Features - 0815fe8 linter: Add `promise/no-return-wrap` (#9537) (therewillbecode) - ae7bb75 linter: Add react/jsx-filename-extension rule (#9474) (Cédric DIRAND) - 50327f3 linter: Add import/exports-last (#9578) (yefan) - 75e4b8d linter: Add import/no-anonymous-default-export rule (#9481) (yefan) - 2f08b16 linter: Add `promise/prefer-catch` (#9488) (therewillbecode) - 41f32ea linter: Allow adding more overrides via `extends` configs (#9475) (camchenry) - fb7cf10 linter: Allowing `plugins` to be extended with `extends` (#9473) (camchenry) - fc74849 linter: Inherit `rules` via the extended config files (#9308) (camchenry) - 3fce826 linter: Add support for `extends` property in oxlintrc (#9217) (camchenry) ### Bug Fixes - 2d42569 linter: Rule `eslint/no-unsafe-optional-chaining` (#9632) (therewillbecode) - a9d7df9 linter: False positive in `unicorn/escape-case` (#9638) (shulaoda) - 3831819 linter: Fix example lint declaration and macro syntax (#9626) (Uli) - 4ca62ab linter: Output right file line and column for `.vue`, `.astro` and `.svelte` files (#9484) (Sysix) - 3105159 linter: Do not output number of rules with nested configs (#9476) (camchenry) - 5ecda01 linter: Support nested extending (#9472) (camchenry) ### Documentation - b7c61e9 linter: Improve docs for `eslint-guard-for-in` (#9658) (therewillbecode) - 1cc43f7 linter: Improve the documentation of `eslint-no-console` (#9612) (therewillbecode) - 608bb77 linter: Improve the docs and add test case for `typescript-no-extra-non-null-assertion` (#9609) (therewillbecode) - 43add5d linter: Better docs for `typescript-no-non-null-asserted-nullish-coalescing` rule (#9610) (therewillbecode) - bd90ce6 linter: Improve the docs and add test cases for `eslint-no-shadow-restricted-names` (#9597) (therewillbecode) - a0c9f7c linter: Improve the documentation of `eslint-no-func-assign` (#9596) (therewillbecode) - ec922e9 linter: Improve the documentation of `typescript-consistent-type-definitions` (#9575) (therewillbecode) - 165c89d linter: Improve the documentation of `typescript-no-namespace` (#9545) (therewillbecode) ### Refactor - c174600 linter: Improve `eslint/no-duplicate-imports` (#9627) (therewillbecode) - 31ba425 linter: Improve `eslint/no-self-assign` (#9635) (therewillbecode) - 03a40df linter: Access scoping from `ctx` directly (#9624) (Boshen) - be5e5dc linter: Improve `unicorn/escape-case` (#9568) (shulaoda) - b7f82fc linter: Improve `unicorn/error-message` (#9560) (shulaoda) - 069ef2d linter: Improve `promise/no-nesting` (#9544) (therewillbecode) - 62bffed rust: Allow a few annoying clippy rules (#9588) (Boshen) ### Testing - 934a387 linter: Remove test dependency on oxlint (#9513) (camchenry) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extendskeyword #9307Allows for using the
extendskeyword to chain multiple extended config files together: for example, a package config that extends a base config that extends a config fromnode_modulesand so on.I don't really love what we're having to do here with using both
override_rulesandConfigStoreBuilder.with_rule. I think there is a refactoring opportunity to merge some functionality together here, but I don't want to refactor and optimize before we have a more comprehensive test suite.