refactor(rust): allow a few annoying clippy rules (#9588)

Seems like an annoying rule

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

Author: Boshen

Cargo.toml

@@ -69,8 +69,11 @@ too_many_lines = "allow"
 must_use_candidate = "allow"
 # Too annoying, we import by name anyway.
 wildcard_imports = "allow"
-# used_underscore_binding= "allow"
 doc_markdown = "allow"
+similar_names = "allow"
+fn_params_excessive_bools = "allow"
+complexity = { level = "warn", priority = -1 }
+too_many_arguments = "allow"
 # nursery
 nursery = { level = "warn", priority = -1 }
 # `const` functions do not make sense for our project because this is not a `const` library.

apps/oxlint/src/command/lint.rs

@@ -443,7 +443,6 @@ mod lint_options {
     }
 
     #[test]
-    #[expect(clippy::similar_names)]
     fn multiple_paths() {
         let temp_dir = tempfile::tempdir().expect("Could not create a temp dir");
         let file_foo = temp_dir.path().join("foo.js");

crates/oxc_ast/src/ast_builder_impl.rs

@@ -287,7 +287,6 @@ impl<'a> AstBuilder<'a> {
     }
 
     /// Build a [`Function`] with `scope_id`.
-    #[expect(clippy::too_many_arguments)]
     #[inline]
     pub fn alloc_function_with_scope_id<T1, T2, T3, T4, T5>(
         self,

crates/oxc_ast/src/generated/ast_builder.rs

@@ -3,11 +3,7 @@
 
 //! AST node factories
 
-#![expect(
-    clippy::default_trait_access,
-    clippy::too_many_arguments,
-    clippy::fn_params_excessive_bools
-)]
+#![expect(clippy::default_trait_access)]
 
 use std::cell::Cell;
 

crates/oxc_ecmascript/src/constant_evaluation/mod.rs

@@ -499,7 +499,6 @@ impl<'a> ConstantEvaluation<'a> for ComputedMemberExpression<'a> {
     }
 }
 
-#[expect(clippy::similar_names)]
 fn is_less_than<'a>(
     ctx: &impl ConstantEvaluationCtx<'a>,
     x: &Expression<'a>,

crates/oxc_linter/src/module_graph_visitor.rs

@@ -142,7 +142,6 @@ struct ModuleGraphVisitor {
 }
 
 impl ModuleGraphVisitor {
-    #[expect(clippy::too_many_arguments)]
     fn filter_fold_while<
         T,
         Filter: Fn(ModulePair, &ModuleRecord) -> bool,
@@ -172,7 +171,6 @@ impl ModuleGraphVisitor {
         .into_inner()
     }
 
-    #[expect(clippy::too_many_arguments)]
     fn filter_fold_recursive<
         T,
         Filter: Fn(ModulePair, &ModuleRecord) -> bool,

crates/oxc_linter/src/utils/express.rs

@@ -46,7 +46,6 @@ pub fn as_endpoint_registration<'a, 'n>(
 ///
 /// This will yield a lot of false positives if not called on the results of
 /// [`as_endpoint_registration`].
-#[expect(clippy::similar_names)]
 pub fn is_endpoint_handler(maybe_handler: &Expression<'_>) -> bool {
     let params = match maybe_handler {
         Expression::FunctionExpression(f) => &f.params,

crates/oxc_parser/src/js/class.rs

@@ -384,7 +384,6 @@ impl<'a> ParserImpl<'a> {
         }
     }
 
-    #[expect(clippy::too_many_arguments, clippy::fn_params_excessive_bools)]
     fn parse_class_method_definition(
         &mut self,
         span: Span,
@@ -449,7 +448,6 @@ impl<'a> ParserImpl<'a> {
     }
 
     /// `FieldDefinition`[?Yield, ?Await] ;
-    #[expect(clippy::too_many_arguments, clippy::fn_params_excessive_bools)]
     fn parse_class_property_definition(
         &mut self,
         span: Span,
@@ -501,7 +499,6 @@ impl<'a> ParserImpl<'a> {
     }
 
     /// <https://github.com/tc39/proposal-decorators>
-    #[expect(clippy::too_many_arguments, clippy::fn_params_excessive_bools)]
     fn parse_class_accessor_property(
         &mut self,
         span: Span,

crates/oxc_span/src/source_type/mod.rs

@@ -545,7 +545,6 @@ mod tests {
     }
 
     #[test]
-    #[expect(clippy::similar_names)]
     fn test_d_ts_from_path() {
         let dts = SourceType::from_path("foo.d.ts").unwrap();
         let dmts = SourceType::from_path("foo.d.mts").unwrap();

crates/oxc_transformer/src/common/duplicate.rs

@@ -54,7 +54,6 @@ impl<'a> TransformCtx<'a> {
     ///
     /// Returns 3 `Expression`s. The first may be an `AssignmentExpression`,
     /// and must be inserted into output first.
-    #[expect(clippy::similar_names)]
     pub(crate) fn duplicate_expression_twice(
         &self,
         expr: Expression<'a>,

crates/oxc_transformer/src/es2022/class_properties/private_field.rs

@@ -2133,7 +2133,6 @@ impl<'a> ClassProperties<'a, '_> {
     /// * Setter: `_prop.call(_assertClassBrand(Class, object), value)`
     /// * Prop: `_privateFieldSet(_prop, object, value)`
     /// * Prop binding is `None`: `_writeOnlyError("#method")`
-    #[expect(clippy::too_many_arguments)]
     fn create_private_setter(
         &self,
         private_name: &str,

tasks/ast_tools/src/derives/get_span.rs

@@ -120,7 +120,6 @@ impl Derive for DeriveGetSpanMut {
 }
 
 /// Generate `GetSpan` / `GetSpanMut` trait implementation for a type.
-#[expect(clippy::too_many_arguments)]
 fn derive_type(
     type_def: StructOrEnum,
     trait_ident: &Ident,
@@ -149,7 +148,6 @@ fn derive_type(
 }
 
 /// Generate `GetSpan` / `GetSpanMut` trait implementation for a struct.
-#[expect(clippy::too_many_arguments)]
 fn derive_struct(
     struct_def: &StructDef,
     trait_ident: &Ident,

tasks/ast_tools/src/generators/ast_builder.rs

@@ -69,11 +69,7 @@ impl Generator for AstBuilderGenerator {
             //! AST node factories
 
             //!@@line_break
-            #![expect(
-                clippy::default_trait_access,
-                clippy::too_many_arguments,
-                clippy::fn_params_excessive_bools,
-            )]
+            #![expect(clippy::default_trait_access)]
 
             ///@@line_break
             use std::cell::Cell;
@@ -192,7 +188,6 @@ fn generate_builder_methods_for_struct(struct_def: &StructDef, schema: &Schema)
 /// Build a pair of builder methods for a struct.
 ///
 /// This is a separate function as may need to be called twice, with and without semantic ID fields.
-#[expect(clippy::too_many_arguments)]
 fn generate_builder_methods_for_struct_impl(
     struct_def: &StructDef,
     params: &[Param],
@@ -485,7 +480,6 @@ fn generate_builder_method_for_enum_variant(
     output2
 }
 
-#[expect(clippy::too_many_arguments, clippy::similar_names)]
 fn generate_builder_method_for_enum_variant_impl(
     enum_def: &EnumDef,
     struct_def: &StructDef,

tasks/ast_tools/src/schema/defs/enum.rs

@@ -49,7 +49,6 @@ pub struct EnumDef {
 
 impl EnumDef {
     /// Create new [`EnumDef`].
-    #[expect(clippy::too_many_arguments)]
     pub fn new(
         id: TypeId,
         name: String,

tasks/ast_tools/src/schema/defs/struct.rs

@@ -45,7 +45,6 @@ pub struct StructDef {
 
 impl StructDef {
     /// Create new [`StructDef`].
-    #[expect(clippy::too_many_arguments)]
     pub fn new(
         id: TypeId,
         name: String,