refactor: reduce cfg_attr boilerplate with SerAttrs derive
#2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 10, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @overlookmotel and the rest of your teammates on |
CodSpeed Performance ReportMerging #2669 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
03-10-fix_ast_fix_TS_type_for_AssignmentTargetRest_
branch
from
bf0b2eb to
dccedc5
Compare
overlookmotel
force-pushed
the
03-10-refactor_reduce_cfg_attr_boilerplate_with_SerAttrs_derive
branch
from
269b0be to
2cb5b4d
Compare
Boshen
force-pushed
the
03-10-fix_ast_fix_TS_type_for_AssignmentTargetRest_
branch
from
dccedc5 to
3b12bfd
Compare
Base automatically changed from
03-10-fix_ast_fix_TS_type_for_AssignmentTargetRest_
to
main
March 11, 2024 04:42
Boshen
force-pushed
the
03-10-refactor_reduce_cfg_attr_boilerplate_with_SerAttrs_derive
branch
from
2cb5b4d to
0cec2c0
Compare
Boshen
deleted the
03-10-refactor_reduce_cfg_attr_boilerplate_with_SerAttrs_derive
branch
overlookmotel
added a commit
that referenced
this pull request
Mar 13, 2024
Add `SerAttrs` derive to a few types that I missed out in #2669.
overlookmotel
added a commit
that referenced
this pull request
Jul 20, 2024
Remove a ton of `#[cfg_attr(feature = "serialize", serde(...))]` boilerplate from AST type definitions. Before: `#[cfg_attr(feature = "serialize", serde(flatten))]` After: `#[serde(flatten)]` This is a reprise of #2669, which was later reverted, but this time doing it using our existing zero-cost `#[ast]` dummy macro attr, so no compile time penalty this time around. This makes no difference to either runtime or compile time behavior, purely removes the `cfg_attr` boilerplate and makes the code easier to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2641.
Also added
tsifyattribute to theSerAttrsderive macro, so#[cfg_attr(feature = "wasm", tsify(...))]can also be reduced to#[tsify(...)].