Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast): import Tsify to shorten code #2665

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Mar 10, 2024

Pure refactor. Import tsify::Tsify in files that use it, so then shorten a load of:

- #[cfg_attr(feature = "wasm", derive(tsify::Tsify))]
+ #[cfg_attr(feature = "wasm", derive(Tsify))]

@github-actions github-actions bot added A-semantic Area - Semantic A-ast Area - AST labels Mar 10, 2024
Copy link

codspeed-hq bot commented Mar 10, 2024

CodSpeed Performance Report

Merging #2665 will not alter performance

Comparing 03-10-refactor_ast_import_Tsify_to_shorten_code (b8e542c) with main (d47f0e2)

Summary

✅ 29 untouched benchmarks

Base automatically changed from 03-10-fix_ast_rename_TSIndexSignatureName_in_JSON_AST to main March 10, 2024 17:11
@overlookmotel overlookmotel force-pushed the 03-10-refactor_ast_import_Tsify_to_shorten_code branch from d0da8f4 to b8e542c Compare March 10, 2024 17:15
Copy link
Member

Boshen commented Mar 11, 2024

Merge activity

  • Mar 11, 12:36 AM EDT: @Boshen started a stack merge that includes this pull request via Graphite.
  • Mar 11, 12:37 AM EDT: @Boshen merged this pull request with Graphite.

@Boshen Boshen merged commit cba1e2f into main Mar 11, 2024
21 of 35 checks passed
@Boshen Boshen deleted the 03-10-refactor_ast_import_Tsify_to_shorten_code branch March 11, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants