Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perfomance metrics tutorial #117

Merged
merged 6 commits into from
Sep 29, 2020
Merged

Perfomance metrics tutorial #117

merged 6 commits into from
Sep 29, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Aug 27, 2020

This PR is related with this other PR gazebosim/gazebo-classic#2819 which includes a new message called performanceMetrics.proto. This tutorial it's to understand the readings.

Signed-off-by: ahcorde ahcorde@gmail.com

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 27, 2020
@ahcorde ahcorde requested a review from iche033 August 27, 2020 09:21
@ahcorde ahcorde self-assigned this Aug 27, 2020
Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from iche033 September 1, 2020 09:57
@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 1, 2020

@iche033 I updated the tutorial with the changes made on the performance metrics PR


# Learn how to read the measurements

We are going to compare the results between physics (contact) and rendering (camera) based sensors and the differences
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tutorial no longer has the physics (contact) sensor values?

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 2, 2020

  • Fixed real time factor in the Gazebo PR
  • Included contact sensor section
  • Link to Physics parameters

@ahcorde ahcorde requested a review from iche033 September 2, 2020 10:53
ahcorde and others added 2 commits September 3, 2020 14:42
Signed-off-by: ahcorde <ahcorde@gmail.com>
…ions

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033
Copy link
Contributor

iche033 commented Sep 3, 2020

I made some changes in a3342cd. Most of them are minor. I removed the framerate numbers in the Real time update section as it does not correspond to the values shown and added an explanation for the values that are 0.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde merged commit 72436d6 into master Sep 29, 2020
@ahcorde ahcorde deleted the ahcorde/performance_metrics branch September 29, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants