-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
align ci runners to osbuild-composer #367
Open
alexxa
wants to merge
1
commit into
osbuild:main
Choose a base branch
from
alexxa:align_ci_runners
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@narmaku Nico, osbuild-composer has two runners here. Is there any reason why we have/had only one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, back in the days with Juan (former Image Builder team member) we discovered that you only need one runner to prepare the internals for all versions and architectures.
So, we reached to the conclusion that we don't really need both to run, just one. However this information is from ~2 years ago and may be wrong. Better to double-check with someone from osbuild. CC @thozza
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ours
.gitlab-ci.yml
has differentrules
set for the job, see https://github.com/osbuild/osbuild-composer/blob/9b850de9f1f113744ad230420c2ce115f9afe610/.gitlab-ci.yml#L167-L168As a result, only one runner is used, depending on the RHEL major version it runs for.
Examples:
9.6 nightly pipeline - https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/pipelines/1688676319
10.0 nightly pipeline - https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/pipelines/1688571275
So our case is different from yours, mainly because of the
rules
.