Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align ci runners to osbuild-composer #367

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexxa
Copy link
Collaborator

@alexxa alexxa commented Feb 24, 2025

Description

This PR aligns runners with osbuild-composer ones as per PR4616

Close CLOUDX-1186

Changes

  • CI runners to match osbuild-composer ones as per PR4616

@@ -66,6 +66,7 @@ prepare-rhel-internal-runners:
- RUNNER:
# NOTE: 1 runner prepares for all arches b/c subsequent jobs download
# artifacts from all previous jobs and the last one wins
- aws/rhel-9.6-nightly-x86_64
- aws/rhel-10.0-nightly-x86_64
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@narmaku Nico, osbuild-composer has two runners here. Is there any reason why we have/had only one?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, back in the days with Juan (former Image Builder team member) we discovered that you only need one runner to prepare the internals for all versions and architectures.

So, we reached to the conclusion that we don't really need both to run, just one. However this information is from ~2 years ago and may be wrong. Better to double-check with someone from osbuild. CC @thozza

Copy link
Member

@thozza thozza Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ours .gitlab-ci.yml has different rules set for the job, see https://github.com/osbuild/osbuild-composer/blob/9b850de9f1f113744ad230420c2ce115f9afe610/.gitlab-ci.yml#L167-L168

As a result, only one runner is used, depending on the RHEL major version it runs for.
Examples:
9.6 nightly pipeline - https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/pipelines/1688676319
10.0 nightly pipeline - https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/pipelines/1688571275

So our case is different from yours, mainly because of the rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants