-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github action for testing latest quarkus master
with latest graal master
#2349
Conversation
This github action will be ultimately set to run nightly. It is currently set to run on push for testing purposes till it gets reviewed. Comments on how to improve it are welcome :) |
Hello Foivos Zakkak, thanks for contributing a PR to our project! We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address fzakkak -(at)- redhat -(dot)- com. You can sign it at that link. If you think you've already signed it, please comment below and we'll check. |
The @redhat.com email address was the clue. He should be covered by the Red Hat OCA as he works for Red Hat. |
Foivos Zakkak has signed the Oracle Contributor Agreement (based on email address fzakkak -(at)- redhat -(dot)- com) so can contribute to this repository. |
Hi @zakkak, thanks for the PR. I'll add a couple of comments. |
0e234cc
to
5599011
Compare
I have also tried building graalvm with |
I'm fine with running Looking at your list of excluded components, I'd run:
Which includes:
However, this would be closer to what we ship (no
|
I'm waiting for the confirmation that we can add GitHub actions to this repository. I'll keep you updated. |
Good news: we can add GitHub actions to this repository. I'll work on integrating this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zakkak can you please update this action to run nightly and double-check that the test matrix is still up-to-date?
2a5a646
to
3826faa
Compare
.github/workflows/quarkus.yml
Outdated
with: | ||
java-version: 11 | ||
- name: Reclaim Disk Space | ||
run: .github/ci-prerequisites.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zakkak, please add .github/ci-prerequisites.sh
or remove this step.
Run .github/ci-prerequisites.sh
/home/runner/work/_temp/cfae83e8-7803-4c08-9ef8-59de516c2f55.sh: line 1: .github/ci-prerequisites.sh: No such file or directory
##[error]Process completed with exit code 127.
https://github.com/zakkak/mandrel/runs/993279323?check_suite_focus=true
b8e94a3
to
1ad17f5
Compare
@ansalond please check latest run at https://github.com/zakkak/mandrel/runs/994834795?check_suite_focus=true |
Thanks! I see some failures, should we open dedicated issues? |
1ad17f5
to
2bfac9c
Compare
Yes, I think the right way to move forward is to open dedicated issues where the graal and the quarkus communities can work together. |
Perfect! I created the |
Great, thanks @ansalond ! I think the PR is ready to be merged. The conditions that trigger the action are already changed. |
This PR adds a github action for building the latest graal and then using it to build and test the latest quarkus.
The goal of this github action is to assist the graalvm team in detecting changes that break quarkus.