Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[community] Labeling of Quarkus related issues #2767

Closed
zakkak opened this issue Aug 19, 2020 · 9 comments
Closed

[community] Labeling of Quarkus related issues #2767

zakkak opened this issue Aug 19, 2020 · 9 comments
Assignees
Labels
feature quarkus quarkus related issue

Comments

@zakkak
Copy link
Collaborator

zakkak commented Aug 19, 2020

Feature request

Now that graal has a github action testing the latest Quarkus release with the latest Graal (#2349) and a new label 'quarkus', it would be nice to have some help in labelling all the existing quarkus-related issues/PRs as well as the future ones.

Is your feature request related to a problem? Please describe.
Currently there is no way for third parties

Describe the solution you'd like.
Ideally I would like this to be automated.
Quarkus is using an autolabel workflow that runs periodically and automatically labels issues matching some criteria. Using a similar workflow would be of great help.

Describe who do you think will benefit the most.

  • GraalVM contributors
  • Quarkus contributors

Describe alternatives you've considered.
Alternatively, we could have a new issue template for quarkus-related issues and possibly give "Triage" permissions to some Quarkus contributors.

Express whether you'd like to help contributing this feature
I would happily contribute the workflow and configuration for the autolabel part.

Relates to #2764

@munishchouhan
Copy link
Contributor

@zakkak Thanks for suggestion,
We will work on it and let you know our thoughts

@munishchouhan munishchouhan added the quarkus quarkus related issue label Aug 21, 2020
@dougxc
Copy link
Member

dougxc commented Aug 21, 2020

@RoxaBee I like the idea of the automated labelling of Quarkus issues - do you see any problem with it?

@dougxc
Copy link
Member

dougxc commented Aug 21, 2020

@zakkak I like the automated labelling. I see it has a dependency on docker://maxandersen/jbang-issuelabeler. Can you please explain more about that dependency.

@RoxaBee
Copy link
Contributor

RoxaBee commented Aug 22, 2020

Alternatively, we could have a new issue template for quarkus-related issues and possibly give "Triage" permissions to some Quarkus contributors.

That would work probably work as well.

@zakkak
Copy link
Collaborator Author

zakkak commented Aug 24, 2020

@zakkak I like the automated labelling. I see it has a dependency on docker://maxandersen/jbang-issuelabeler. Can you please explain more about that dependency.

Hello @dougxc to label the issues Quarkus is using the issuelabeler GitHub action. GitHub actions can be written either as:

  • javascript actions (most popular, and that's the format of the official actions, like checkout)
  • docker container actions (this enables devs to write the action in the language of their choice)
  • composite run steps actions (that's fairly new, and allows simple steps to be packaged in an action for reuse across workflows)

For more info see here

Now the issuelabeler action is a docker container action (thus the dependency on docker://maxandersen/jbang-issuelabeler).
The source code of the action is available in this repo (it contains both the action source, the dockerfile and the scripts that generate the docker image).
To have a look at what the action does please see the java source code

@dougxc
Copy link
Member

dougxc commented Aug 24, 2020

@RoxaBee please update here once we know how to assign the Triage role to our Quarkus collaborators.

@dougxc dougxc assigned RoxaBee and unassigned dougxc Oct 30, 2020
@RoxaBee
Copy link
Contributor

RoxaBee commented Oct 30, 2020

Our policy is to only allow GitHub and in-org published actions. There is a GitHub published issue labeler
https://github.com/github/issue-labeler
However looking at the code this uses GITHUB_TOKEN which we would consider overprivileged since it allows full write access to a repo. We think this should run with an Oauth token that has triage permission level. I am following up on this.

However as previously suggested, we can have a new issue template for Quarkus related issues and possibly give "Triage" permission to Quarkus contributors. That Triage permission level is not currently available in our org but will be soon.

@RoxaBee
Copy link
Contributor

RoxaBee commented Jun 7, 2021

Yes we can now give Triage permissions to Quarkus contributors! Please someone email me or slack me.

@zakkak
Copy link
Collaborator Author

zakkak commented Jun 11, 2021

Triage permissions have now been granted. Thank you!

@zakkak zakkak closed this as completed Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature quarkus quarkus related issue
Projects
None yet
Development

No branches or pull requests

4 participants