feat(ansible): Configure verbosity via annotation #2102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
djzager
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
/retest |
1 similar comment
|
/retest |
camilamacedo86
added
language/ansible
This makes it possible to create a CR with an annotation, specifically `"ansible.operator-sdk/verbosity"`, to override the verbosity of `ansible-runner` commands for a given CR. - Store the verbosity on `runner` - Update `cmdFuncType` to take verbosity and `*exec.Cmd` to convert integer value of verbosity to string - In `Run()` get verbosity annotation from CR (if it exists) and use that value when executing the `cmdFunc`
djzager
force-pushed
the
ansible-verbosity-annotation
branch
from
01fc01f to
048a53d
Compare
djzager
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
|
@djzager: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci-robot
added
the
ok-to-test
|
/retest |
camilamacedo86
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to create a CR with an annotation, specifically
"ansible.operator-sdk/verbosity", to override the verbosity ofansible-runnercommands for a given CR.runnercmdFuncTypeto take verbosity and*exec.Cmdto convertinteger value of verbosity to string
Run()get verbosity annotation from CR (if it exists) and usethat value when executing the
cmdFuncCloses #2091
Checklist:
advanced_options.mddocumentation for Ansible Operators