Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Ansible Verbosity via Annotation #2091

Closed
djzager opened this issue Oct 22, 2019 · 3 comments · Fixed by #2102
Closed

Configure Ansible Verbosity via Annotation #2091

djzager opened this issue Oct 22, 2019 · 3 comments · Fixed by #2102
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/ansible Issue is related to an Ansible operator project

Comments

@djzager
Copy link
Contributor

djzager commented Oct 22, 2019

Feature Request

#2087 makes it possible to configure Ansible verbosity via:

  1. ansible-verbosity command line flag
  2. environment variable in the operator container of the form ANSIBLE_VERBOSITY_<kind>_<group>

Also, the maxRunnerArtifacts (how many old executions of ansible-runner to keep around) is configurable via an annotation, for example ansible.operator-sdk/max-runner-artifacts: "100".

Describe the solution you'd like

It should be possible to make the verbosity configurable via an annotation, for example ansible.operator-sdk/verbosity: "6".

@joelanford joelanford added language/ansible Issue is related to an Ansible operator project kind/feature Categorizes issue or PR as related to a new feature. labels Oct 22, 2019
@joelanford
Copy link
Member

@fabianvf this sounds pretty reasonable to me. thoughts?

@djzager assuming Fabian is in agreement, would you be interested and have the time to submit a PR for this?

@fabianvf
Copy link
Member

Yeah this sounds great to me, would make the process of debugging so much easier. It might be necessary for us to include an admin level option to disable processing these annotations, just to prevent some sort of user-side attack if the admin wants to keep the logs/other stuff like runner artifacts locked down (ie, could balloon the number of artifacts by triggering runs, and I'm not sure how verbosity levels impact performance but writing everything to stdout likely isn't free).

@djzager
Copy link
Contributor Author

djzager commented Oct 22, 2019

@djzager assuming Fabian is in agreement, would you be interested and have the time to submit a PR for this?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. language/ansible Issue is related to an Ansible operator project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants