Replace qs with URLSearchParams #5592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var href = link.href.split(/[?#]/)[0], | ||
| args = Qs.parse(link.search.substring(1)), | ||
| editlink = $(link).hasClass("editlink"); | ||
| let href = link.href.split(/[?#]/)[0]; |
There was a problem hiding this comment.
Not sure if this is a good and correct change:
Suggested change
| let href = link.href.split(/[?#]/)[0]; | |
| let href = link.protocol + '//' + link.hostname + link.pathname; |
There was a problem hiding this comment.
I'm not actually changing that line though? Other than replacing var with let?
There was a problem hiding this comment.
I thought the general goal was to replace complex code with modern APIs.
If this is an external library or own code is for me not important.
Both approaches (doing one single task vs bigger refactorings) have pros and cons.
tomhughes
force-pushed
the
urlsearchparams
branch
2 times, most recently
from
f288601 to
05c1f53
Compare
AntonKhorev
reviewed
Feb 2, 2025
| @@ -39,7 +37,7 @@ OSM.initializeContextMenu = function (map) { | |||
| callback: function describeLocation(e) { | |||
| const [lat, lon] = OSM.cropLocation(e.latlng, map.getZoom()).map(encodeURIComponent); | |||
There was a problem hiding this comment.
encodeURIComponent here probably doesn't do anything
There was a problem hiding this comment.
Maybe, but it's not something new in this pull request?
AntonKhorev
reviewed
Feb 2, 2025
tomhughes
force-pushed
the
urlsearchparams
branch
from
05c1f53 to
46cd3a1
Compare
tyrasd
added a commit
to tyrasd/openstreetmap-website
that referenced
this pull request
Feb 12, 2025
the current version of iD (v2.31, before the fix for https://github.com/openstreetmap/iD/issue/10761: openstreetmap/iD#10766), does not fully support `x-www-form-urlencoded` "query-style" strings in the hash: Specifically, spaces encoded as `+` will not be decoded back to ` `. This workaround essentially temporarily reverts the behaviour of the website to the state before openstreetmap#5592, and can be dropped again with the next minor version upgrade of iD (`v2.32`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As javascript now has a builtin way to parse URL search parameters we don't really need the qs module any more, so replace it with the builtin support.