Fix + symbol appearing in changeset comments from external tools
#10766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replacing the homebrew implementation to build something resembling a x-www-form-urlencoded string
tyrasd
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Thanks. I expanded this a bit to add tests, and make the matching utilQsString method also use URLSearchParams instead of the homebrew construction of the params string. Further, I added to the API.md documentation the explicit format the hash parameters are to be supplied.
tyrasd
added a commit
to tyrasd/openstreetmap-website
that referenced
this pull request
Feb 12, 2025
the current version of iD (v2.31, before the fix for https://github.com/openstreetmap/iD/issue/10761: openstreetmap/iD#10766), does not fully support `x-www-form-urlencoded` "query-style" strings in the hash: Specifically, spaces encoded as `+` will not be decoded back to ` `. This workaround essentially temporarily reverts the behaviour of the website to the state before openstreetmap#5592, and can be dropped again with the next minor version upgrade of iD (`v2.32`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10761