Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS-3699: Create new tech preview job for user provisioned DNS installs (Aws) #57437

Merged
merged 1 commit into from
Dec 23, 2024
Merged

CORS-3699: Create new tech preview job for user provisioned DNS installs (Aws) #57437

merged 1 commit into from
Dec 23, 2024

Conversation

barbacbd
Copy link
Contributor

@barbacbd barbacbd commented Oct 3, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 3, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2024 •
edited by openshift-ci bot
Loading

@barbacbd: This pull request references CORS-3699 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@barbacbd
Copy link
Contributor Author

barbacbd commented Oct 3, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2024
@barbacbd
Copy link
Contributor Author

barbacbd commented Oct 3, 2024

/cc @patrickdillon
/cc @sadasu

@openshift-ci openshift-ci bot requested review from patrickdillon and sadasu October 3, 2024 15:34
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 3, 2024
@openshift-ci openshift-ci bot requested review from dgoodwin and neisw October 3, 2024 15:39
@barbacbd barbacbd force-pushed the CORS-3699 branch 2 times, most recently from 4a21297 to 9914dec Compare October 21, 2024 18:59
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 21, 2024
@barbacbd barbacbd force-pushed the CORS-3699 branch 3 times, most recently from 6105a66 to 8df3853 Compare October 22, 2024 11:27
@barbacbd
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2024
@sadasu sadasu mentioned this pull request Nov 21, 2024
Merged
@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 21, 2024
@sadasu
Copy link
Contributor

sadasu commented Nov 22, 2024

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 22, 2024
sadasu
sadasu reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@sadasu sadasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

patrickdillon
patrickdillon reviewed Nov 22, 2024
View reviewed changes
ci-operator/config/openshift/installer/openshift-installer-release-4.18.yaml Outdated
@@ -374,6 +374,16 @@ tests:
cluster_profile: aws
workflow: openshift-e2e-aws-proxy
timeout: 6h0m0s
- always_run: false
as: e2e-aws-user-provisioned-dns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
as: e2e-aws-user-provisioned-dns
as: e2e-aws-ovn-user-provisioned-dns

@barbacbd barbacbd force-pushed the CORS-3699 branch 2 times, most recently from 7c01ad5 to 7eeebc1 Compare November 22, 2024 17:17
@r4f4
Copy link
Contributor

r4f4 commented Nov 22, 2024

/pj-rehearse pull-ci-openshift-installer-master-e2e-aws-ovn-user-provisioned-dns pull-ci-openshift-installer-master-e2e-aws-ovn pull-ci-openshift-installer-release-4.17-e2e-aws-ovn pull-ci-ComplianceAsCode-compliance-operator-master-e2e-aws-parallel

@openshift-ci-robot
Copy link
Contributor

@r4f4: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@r4f4: job(s): either don't exist or were not found to be affected, and cannot be rehearsed

@r4f4
Copy link
Contributor

r4f4 commented Nov 22, 2024

I don't see a release-4.19-user-provisioned-dns so I think you need to add it to the 4.19 config as well.

@barbacbd barbacbd force-pushed the CORS-3699 branch 2 times, most recently from f2253a1 to 373e18b Compare December 20, 2024 14:35
@sadasu
Copy link
Contributor

sadasu commented Dec 20, 2024

/pj-rehearse pull-ci-openshift-installer-master-e2e-aws-ovn-user-provisioned-dns pull-ci-openshift-installer-master-e2e-aws-ovn pull-ci-openshift-installer-release-4.17-e2e-aws-ovn pull-ci-ComplianceAsCode-compliance-operator-master-e2e-aws-parallel

@openshift-ci-robot
Copy link
Contributor

@sadasu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@sadasu: job(s): pull-ci-openshift-installer-master-e2e-aws-ovn-user-provisioned-dns, pull-ci-openshift-installer-master-e2e-aws-ovn either don't exist or were not found to be affected, and cannot be rehearsed

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@barbacbd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-quay-quay-operator-master-ocp-latest-e2e quay/quay-operator presubmit Registry content changed
pull-ci-quay-quay-operator-redhat-3.9-ocp-latest-e2e quay/quay-operator presubmit Registry content changed
pull-ci-quay-quay-operator-redhat-3.8-ocp-latest-e2e quay/quay-operator presubmit Registry content changed
pull-ci-codeready-toolchain-member-operator-master-e2e codeready-toolchain/member-operator presubmit Registry content changed
pull-ci-openshift-open-telemetry-opentelemetry-operator-main-opentelemetry-product-ocp-4.16-stage-opentelemetry-stage-tests-fips openshift/open-telemetry-opentelemetry-operator presubmit Registry content changed
pull-ci-openshift-open-telemetry-opentelemetry-operator-main-opentelemetry-product-ocp-4.17-stage-opentelemetry-stage-tests openshift/open-telemetry-opentelemetry-operator presubmit Registry content changed
pull-ci-openshift-open-telemetry-opentelemetry-operator-main-opentelemetry-product-ocp-4.17-stage-opentelemetry-stage-tests-fips openshift/open-telemetry-opentelemetry-operator presubmit Registry content changed
pull-ci-openshift-open-telemetry-opentelemetry-operator-main-opentelemetry-product-ocp-4.14-arm-stage-opentelemetry-stage-tests openshift/open-telemetry-opentelemetry-operator presubmit Registry content changed
pull-ci-openshift-open-telemetry-opentelemetry-operator-main-opentelemetry-product-ocp-4.12-stage-opentelemetry-stage-tests openshift/open-telemetry-opentelemetry-operator presubmit Registry content changed
pull-ci-openshift-open-telemetry-opentelemetry-operator-main-upstream-ocp-4.13-amd64-aws-ipi-ovn-hypershift-opentelemetry-e2e-tests openshift/open-telemetry-opentelemetry-operator presubmit Registry content changed
pull-ci-openshift-open-telemetry-opentelemetry-operator-main-opentelemetry-product-ocp-4.16-stage-opentelemetry-stage-tests openshift/open-telemetry-opentelemetry-operator presubmit Registry content changed
pull-ci-openshift-open-telemetry-opentelemetry-operator-main-upstream-ocp-4.16-amd64-aws-ipi-shared-vpc-phz-sts-opentelemetry-e2e-tests openshift/open-telemetry-opentelemetry-operator presubmit Registry content changed
pull-ci-openshift-csi-external-provisioner-master-okd-scos-e2e-aws-ovn openshift/csi-external-provisioner presubmit Registry content changed
pull-ci-openshift-csi-external-provisioner-release-4.18-okd-scos-e2e-aws-ovn openshift/csi-external-provisioner presubmit Registry content changed
pull-ci-openshift-csi-external-provisioner-master-e2e-aws-csi openshift/csi-external-provisioner presubmit Registry content changed
pull-ci-openshift-csi-external-provisioner-release-4.20-e2e-aws-csi openshift/csi-external-provisioner presubmit Registry content changed
pull-ci-openshift-csi-external-provisioner-release-4.19-e2e-aws-csi openshift/csi-external-provisioner presubmit Registry content changed
pull-ci-openshift-csi-external-provisioner-release-4.18-e2e-aws-csi openshift/csi-external-provisioner presubmit Registry content changed
pull-ci-openshift-csi-external-provisioner-release-4.17-e2e-aws-csi openshift/csi-external-provisioner presubmit Registry content changed
pull-ci-openshift-csi-external-provisioner-release-4.16-e2e-aws-csi openshift/csi-external-provisioner presubmit Registry content changed
pull-ci-openshift-csi-external-provisioner-release-4.15-e2e-aws-csi openshift/csi-external-provisioner presubmit Registry content changed
pull-ci-openshift-csi-external-provisioner-release-4.14-e2e-aws-csi openshift/csi-external-provisioner presubmit Registry content changed
pull-ci-openshift-csi-external-provisioner-release-4.13-e2e-aws-csi openshift/csi-external-provisioner presubmit Registry content changed
pull-ci-openshift-csi-external-provisioner-release-4.12-e2e-aws-csi openshift/csi-external-provisioner presubmit Registry content changed
pull-ci-openshift-csi-external-provisioner-release-4.11-e2e-aws-csi openshift/csi-external-provisioner presubmit Registry content changed

A total of 12342 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/installer/master/e2e-aws-ovn-user-provisioned-dns 7eeebc1 link unknown /pj-rehearse pull-ci-openshift-installer-master-e2e-aws-ovn-user-provisioned-dns
ci/rehearse/ComplianceAsCode/compliance-operator/master/e2e-aws-parallel 373e18b link unknown /pj-rehearse pull-ci-ComplianceAsCode-compliance-operator-master-e2e-aws-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sadasu
Copy link
Contributor

sadasu commented Dec 23, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: barbacbd, patrickdillon, sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadasu
Copy link
Contributor

sadasu commented Dec 23, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@sadasu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Dec 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 09dd20c into openshift:master Dec 23, 2024
17 checks passed
tmihalac pushed a commit to tmihalac/release that referenced this pull request Dec 23, 2024
@barbacbd @tmihalac
CORS-3699: Create new tech preview job for user provisioned DNS insta…
57f541d 
…lls (Aws) (openshift#57437)
yingzhanredhat pushed a commit to yingzhanredhat/release that referenced this pull request Dec 24, 2024
@barbacbd @yingzhanredhat
CORS-3699: Create new tech preview job for user provisioned DNS insta…
c341aee 
…lls (Aws) (openshift#57437)
krishvoor pushed a commit to krishvoor/release that referenced this pull request Jan 29, 2025
@barbacbd @krishvoor
CORS-3699: Create new tech preview job for user provisioned DNS insta…
27923bf 
…lls (Aws) (openshift#57437)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgoodwin dgoodwin Awaiting requested review from dgoodwin

@neisw neisw Awaiting requested review from neisw

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@sadasu sadasu Awaiting requested review from sadasu

@r4f4 r4f4 Awaiting requested review from r4f4

Assignees

@r4f4 r4f4

@sadasu sadasu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@barbacbd @openshift-ci-robot @openshift-bot @sadasu @patrickdillon @r4f4