CORS-3713: Extend in-cluster DNS support to AWS Platform

[sadasu]

In-cluster DNS support was previously added for the GCP platform. Only the platform specific portions of that solution have been updated to include the AWS platform.

- What I did

- How to verify it

- Description for the changelog

[openshift-ci-robot]

@sadasu: This pull request references CORS-3713 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

In-cluster DNS support was previously added for the GCP platform. Only the platform specific portions of that solution have been updated to include the AWS platform.

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[sadasu]

@yuqi-zhang Could you PTAL?

[sadasu]

/retest-required

[yuqi-zhang]

logically seems fine, although I don't know how to test this. Is this covered by any existing CI? Alternatively, maybe this should be QE pre-verified?

[sadasu]

logically seems fine, although I don't know how to test this. Is this covered by any existing CI? Alternatively, maybe this should be QE pre-verified?

Will be tested by both QE and CI. This tech preview CI job is being added to test this feature.

[mkowalski]

/lgtm

As discussed via Slack, looks good because it's basically copy-pasta of the code handling GCP extending the logic for AWS. But if after the feature freeze it turns out we need additional implementation in baremetal-runtimecfg, then we should be reverting this one here.

I hope the current code in runtimecfg handles cloud platforms "all-at-once", but we (on-prem networking) never really tested the use of baremetal-runtimecfg in non-metal platforms so there may be gaps.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkowalski, sadasu, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sadasu]

As discussed via Slack, looks good because it's basically copy-pasta of the code handling GCP extending the logic for AWS. But if after the feature freeze it turns out we need additional implementation in baremetal-runtimecfg, then we should be reverting this one here.

I hope the current code in runtimecfg handles cloud platforms "all-at-once", but we (on-prem networking) never really tested the use of baremetal-runtimecfg in non-metal platforms so there may be gaps.

Yes, code added to baremetal-runtimecfg is generic for cloud platforms and does not need any additional changes to add support for AWS (and later Azure).

[sadasu]

/label acknowledge-critical-fixes-only

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 54ee389 and 2 for PR HEAD 6b0ad96 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9856ad1 and 1 for PR HEAD 6b0ad96 in total

[openshift-ci]

@sadasu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	6b0ad96	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[sadasu]

/test e2e-aws-ovn-upgrade

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.19.0-202411220907.p0.g9a8ee32.assembly.stream.el9.
All builds following this will include this PR.