Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add defineCloudflareConfig utility #412

Merged
merged 23 commits into from
Feb 27, 2025
Merged

add defineCloudflareConfig utility #412

merged 23 commits into from
Feb 27, 2025

Conversation

dario-piotrowicz
Copy link
Contributor

@dario-piotrowicz dario-piotrowicz commented Feb 25, 2025 •
edited
Loading

this change adds a new defineCloudflareConfig utility that developers can use in their open-next.config.ts file to easily generate a configuration compatible with the adapter

Docs PR: opennextjs/docs#84

resolves #114

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 53e43d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@opennextjs/cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 25, 2025 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@412

commit: 53e43d2

@dario-piotrowicz
Copy link
Contributor Author

@conico974 what I'm doing here is very close to withCloudflare but this defineConfig is more restricted/focused on just our adapter, while as far as I can tell withCloudflare is much more flexible.

Do you think that this API makes sense? or do you think that we should try to align things more?

conico974
conico974 approved these changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just few nit

Do you think that this API makes sense? or do you think that we should try to align things more?

Yeah i think it makes perfect sense, this is enough. If people needs more complex options they can just provide their own open-next.config.ts

@dario-piotrowicz dario-piotrowicz changed the title add defineConfig utility add defineCloudflareConfig utility Feb 26, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/114/defineConfig branch 4 times, most recently from b52ba04 to 70735e6 Compare February 26, 2025 10:13
vicb
vicb approved these changes Feb 26, 2025
View reviewed changes
@dario-piotrowicz dario-piotrowicz mentioned this pull request Feb 26, 2025
Merged
vicb
vicb approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dario-piotrowicz
add defineConfig utility
8b3e3bc 
this change adds a new `defineConfig` utility that developers can use in their `open-next.config.ts`
file to easily generate a configuration compatible with the adapter
dario-piotrowicz and others added 20 commits February 27, 2025 18:34
@dario-piotrowicz
add defineConfig utility
508ec2c 
this change adds a new `defineConfig` utility that developers can use in their `open-next.config.ts`
file to easily generate a configuration compatible with the adapter
@dario-piotrowicz
defineConfig -> defineCloudflareConfig
8017fec
@dario-piotrowicz
remove unnecessary dangerous.enableCacheInterception option
d56c5b0
@dario-piotrowicz
improve jsdoc comments
36cb6d0
@dario-piotrowicz
update some missing open-next.config.ts files
fe3a51b
@dario-piotrowicz @vicb
Update packages/cloudflare/src/api/config.ts
1cb04e3 
Co-authored-by: Victor Berchet <victor@suumit.com>
@dario-piotrowicz
remove unnecessary empty object
6881358
@dario-piotrowicz
remove unnecessary package.json export
ea6e59d
@dario-piotrowicz
re-export defineCloudflareConfig from index
cbbdd6a
@dario-piotrowicz
reorder defineCloudflareConfig import
a95dfcd
@dario-piotrowicz
update jsdoc comments to point to cloudflare caching doc page
24d7032
@dario-piotrowicz @james-elicx
Apply suggestions from code review
7d00c94 
Co-authored-by: James Anderson <james@eli.cx>
@dario-piotrowicz
remove unnecessary async await
c3973ef
@dario-piotrowicz
fix incorrect type
b22e564
@dario-piotrowicz
add back await
b9b9ade
@dario-piotrowicz
bump @opennextjs/aws dependency to https://pkg.pr.new/@opennextjs/…
121c363 
…aws@755`
@dario-piotrowicz @vicb
Apply suggestions from code review
1f3e289 
Co-authored-by: Victor Berchet <victor@suumit.com>
@dario-piotrowicz
fix broken types
f5e69d5
@dario-piotrowicz
use consistent names in overrides
f29e5c0
@dario-piotrowicz
remove no-longer valid changeset
77d2a25
@vicb vicb merged commit 58b200f into main Feb 27, 2025
7 checks passed
@vicb vicb deleted the dario/114/defineConfig branch February 27, 2025 19:21
@workers-frameworks workers-frameworks mentioned this pull request Feb 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conico974 conico974 conico974 approved these changes

@james-elicx james-elicx james-elicx approved these changes

@vicb vicb vicb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Easier way to create an OpenNext config for cloudflare
4 participants
@dario-piotrowicz @vicb @conico974 @james-elicx