Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the new defineCloudflareConfig utility the Cloudflare get-started configuration step #84

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

dario-piotrowicz
Copy link
Contributor

Warning

This PR shouldn't be merged until the changes in opennextjs/opennextjs-cloudflare#412 have been merged and released

Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge after you've released the code.

Thanks 🚀

@dario-piotrowicz
Copy link
Contributor Author

Looks good to merge after you've released the code.

Thanks 🚀

Thanks 🙂

But as I mentioned here: opennextjs/opennextjs-cloudflare#412 (comment)
We might need to revert exporting from the index 🥲

@dario-piotrowicz dario-piotrowicz force-pushed the dario/defineCloudflareConfig branch from 522d81e to 24a8237 Compare February 26, 2025 18:55
@dario-piotrowicz
Copy link
Contributor Author

dario-piotrowicz commented Feb 26, 2025

@james-elicx (and possibly @conico974) would you mind to have a quick look at the caching page update? 🙏

Copy link
Contributor

@conico974 conico974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@james-elicx james-elicx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much nicer :)

@vicb vicb merged commit e3ba077 into main Feb 27, 2025
1 check passed
@vicb vicb deleted the dario/defineCloudflareConfig branch February 27, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants