Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomize the packaging field and try to identify the language of existing values to convert them or prefix them with the language code #6396

Closed
stephanegigandet opened this issue Feb 8, 2022 · 2 comments
Assignees
Labels
✨ Feature Features or enhancements to Open Food Facts server 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies

Comments

@stephanegigandet
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The packaging field is currently not taxonomized, which means that we have entries in a mixture of languages, including for the same product, and we do not know in which language each entry is.

As a result, we display a mix of languages to users, and we sometime fail to correctly parse the packaging tags to use them as input to identify all packaging components and their shape, material, and recycling instructions.

Describe the solution you'd like

  1. Make the packaging field a taxonomized field. It does not mean that we will have a taxonomy entry for each value entered, but at least we will record the language it is supposed to be in, with a 2 letter prefix. e.g. "fr:couvercle en métal"

  2. Try to identify the language of as many existing entries as possible to prefix them with the language. Update the field, and attribute the change to a specific user (e.g. "packbot").

  3. Automatically create a packaging taxonomy that combines packaging shapes, materials, recycling instructions + preservation methods.

  4. Possibly add some combinations of shapes / materials / recycling in the packaging taxonomy. This might not be useful in the long run, as we will phase out the packaging tags as an output field. We will keep it as an input field, but the useful result will be in the packagings array of packaging components.

Describe alternatives you've considered

No response

Additional context

Part of #219

Number of products impacted

No response

Time per product

No response

@stephanegigandet stephanegigandet added ✨ Feature Features or enhancements to Open Food Facts server 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling labels Feb 8, 2022
@stephanegigandet stephanegigandet self-assigned this Feb 8, 2022
stephanegigandet added a commit that referenced this issue Feb 10, 2022
* start of packaging taxonomization

* remove double entries to create combined packaging taxonomy

* Taxonomize the packaging field #6396

* Taxonomize the packaging field #6396

* Taxonomize the packaging field #6396

* Taxonomize the packaging field #6396

* Taxonomize the packaging field #6396

* Taxonomize the packaging field #6396

* Taxonomize the packaging field #6396

* Update lib/ProductOpener/Packaging.pm

Co-authored-by: Alex Garel <alex@garel.org>

* Update scripts/update_all_products.pl

Co-authored-by: Alex Garel <alex@garel.org>

* Update scripts/update_all_products.pl

Co-authored-by: Alex Garel <alex@garel.org>

* Update scripts/update_all_products.pl

Co-authored-by: Alex Garel <alex@garel.org>

* Update lib/ProductOpener/Ecoscore.pm

Co-authored-by: Alex Garel <alex@garel.org>

* Taxonomize the packaging field #6396

* Taxonomize the packaging field #6396

* add list_taxonomy_tags_in_language function to replace display_tags_hierarchy_taxonomy when no html is needed

* Taxonomize the packaging field #6396

* Taxonomize the packaging field #6396

* Taxonomize the packaging field #6396

Co-authored-by: Alex Garel <alex@garel.org>
@stephanegigandet
Copy link
Contributor Author

The packaging values have been prefixed by a language code for all products through this command:

./update_all_products.pl --prefix-packaging --user packbot --key packbot --comment "update_all_products.pl - Taxonomize packaging field #6396"

@stephanegigandet
Copy link
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature Features or enhancements to Open Food Facts server 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

No branches or pull requests

2 participants