Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: rework build docs #665

Merged
merged 1 commit into from
Feb 8, 2021
Merged

feat: rework build docs #665

merged 1 commit into from
Feb 8, 2021

Conversation

Hoverbear
Copy link
Contributor

@Hoverbear Hoverbear commented Jan 28, 2021 •
edited
Loading

This is a work in progress.

Rework much of new contributor documentation.

Remaining Work

  • Add run guide for k8s
  • Add test guide
  • Run user acceptance test

@Hoverbear Hoverbear self-assigned this Jan 28, 2021
@Hoverbear Hoverbear force-pushed the build-docs branch 2 times, most recently from e11f022 to b187f61 Compare January 28, 2021 21:58
gila
gila approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@gila gila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much @Hoverbear 🥇

@Hoverbear Hoverbear force-pushed the build-docs branch 2 times, most recently from 3a20376 to 100ffe2 Compare January 29, 2021 02:06
@Hoverbear Hoverbear requested review from GlennBullingham and removed request for GlennBullingham February 2, 2021 18:35
@Hoverbear
Copy link
Contributor Author

I asked @amanjeev to do some user acceptance testing for me and they report it went well. I've ticked that box.

@Hoverbear
Copy link
Contributor Author

This should be ready.

I note after #669 is merged so we can update with the new images/services.

@Hoverbear Hoverbear marked this pull request as ready for review February 2, 2021 21:43
@Hoverbear Hoverbear force-pushed the build-docs branch 4 times, most recently from d3c48af to 44c77b4 Compare February 2, 2021 22:15
GlennBullingham
GlennBullingham reviewed Feb 8, 2021
View reviewed changes
GlennBullingham
GlennBullingham reviewed Feb 8, 2021
View reviewed changes
GlennBullingham
GlennBullingham approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@GlennBullingham GlennBullingham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nit picks, including one typo. Comments left for those. Otherwise good to go.

@Hoverbear Hoverbear changed the title feat: rework build docs (WIP) feat: rework build docs Feb 8, 2021
@Hoverbear
feat: rework build docs
1aba1a1 
Signed-off-by: Ana Hobden <operator@hoverbear.org>
@Hoverbear
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 8, 2021

Build succeeded:

@bors bors bot merged commit 0a94597 into develop Feb 8, 2021
@bors bors bot deleted the build-docs branch February 8, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gila gila gila approved these changes

@GlennBullingham GlennBullingham GlennBullingham approved these changes

Assignees

@Hoverbear Hoverbear

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hoverbear @gila @GlennBullingham