[logzio] Remove dependency on jaeger/pkg/cache #37834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. |
yurishkuro
approved these changes
Feb 11, 2025
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
|
please don't merge main unless there are merge conflicts shown in GH. Doing so erases the latest CI run and since you're first-time contributor it doesn't run CI automatically, so every time you merge someone need to hit the button and come back to it again. |
yurishkuro
changed the title
yurishkuro
added
the
ready to merge
|
Thank you for explaining it in detail. |
2 tasks
3 tasks
yurishkuro
pushed a commit
to jaegertracing/jaeger
that referenced
this pull request
Feb 12, 2025
<!-- !! Please DELETE this comment before posting. We appreciate your contribution to the Jaeger project! 👋🎉 --> ## Which problem is this PR solving? - Resolves : #6703 - Related to : open-telemetry/opentelemetry-collector-contrib#37834 ## Description of the changes move pkg/cache to internal ## How was this change tested? - ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: won-js <wonjs0116@gmail.com>
|
cc @yotamloe |
atoulme
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove dependency on Jaeger pkg/cache from OTEL Collector contrib
Link to tracking issue
Resolves #37833
Resolves jaegertracing/jaeger#6703
Testing
Documentation