-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add lfp, vanadium, lair, pair battery technologies as storage units #21
add lfp, vanadium, lair, pair battery technologies as storage units #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking nice. Good and efficient job @virio-andreyana!! I tested it locally and it ran through all the way with solving.
Only left a few minor comments/suggestions that you can go over. One general thing that I would add is updating the doc/configtables
descriptions for the changes that were made regarding the config file. Otherwise, can be merged then in my opinion
We will need to make sure that the adjusted efficiency for Adiabatic CAES at 77,45% (?) makes it into our model @virio-andreyana |
Co-authored-by: Daniel Rüdt <117752024+daniel-rdt@users.noreply.github.com>
@virio-andreyana Lily just answered this morning that they want to stick to the default |
I forgot, is that round trip or the efficiency for each charge and discharge? To prevent changing the cost table, we can put this in the config based on https://pypsa-eur.readthedocs.io/en/latest/configuration.html#adjustments. I need to test it first but what do you think? adjustments:
sector:
absolute:
StorageUnit:
pair:
efficiency_store: 0.7745
efficiency_dispatch: 0.7745 |
Nice, good idea. I am not quite sure though if that works with sector-coupled models, i.e. elements added in
@virio-andreyana Maybe you can add this to the config within this PR, it won't work yet as it needs the changes from the PR above. But it will be functional once merged? What do you think? |
@daniel-rdt Well the function that enables that adjustment is I find your idea more elegant, but it depends on how soon will #23 be merged. When do we want to start an initial scenario run? |
Cool, the let's go the overwrites way. I want to get #23 merged today. I still need to make some minor adjustments though. My plan for the initial main scenario runs is to start this tomorrow before the weekend. Then we can have a look Monday, make some adjustments if necessary and have another run on Tuesday if necessary |
TODO list: