Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CrossVMBridgeFulfillment base contracts #168

Merged
merged 17 commits into from
Feb 12, 2025

Conversation

sisyphusSmiling
Copy link
Contributor

@sisyphusSmiling sisyphusSmiling commented Feb 10, 2025

Closes: #166


For contributor use:

  • Targeted PR against main branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@sisyphusSmiling
Copy link
Contributor Author

Update: Scoping the extension of ERC721 as a potential for linearization problems in ERC721 extensions - ref

@sisyphusSmiling
Copy link
Contributor Author

Cherry picked 8eceb59 from #163 to fix CI

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review February 11, 2025 19:07
@sisyphusSmiling sisyphusSmiling requested a review from a team as a code owner February 11, 2025 19:07
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.35%. Comparing base (02aab3f) to head (0ffd27c).
Report is 219 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   86.19%   87.35%   +1.15%     
==========================================
  Files          18       18              
  Lines         884     1020     +136     
==========================================
+ Hits          762      891     +129     
- Misses        122      129       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling changed the title [WIP] Add CrossVMBridgeFulfillment base contracts Add CrossVMBridgeFulfillment base contracts Feb 11, 2025
@sisyphusSmiling sisyphusSmiling self-assigned this Feb 11, 2025
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm certainly not an authority on Solidity, but this seems fine to me!

@sisyphusSmiling
Copy link
Contributor Author

FYI @loic1 I've added exists(uint256) (bool) to the fulfillment base contracts. It will be necessary information in conjunction with isEscrowed

@sisyphusSmiling sisyphusSmiling merged commit 53610ef into main Feb 12, 2025
2 checks passed
@sisyphusSmiling sisyphusSmiling deleted the gio/add-fulfillment-interfaces branch February 12, 2025 21:33
@loic1
Copy link

loic1 commented Feb 12, 2025

FYI @loic1 I've added exists(uint256) (bool) to the fulfillment base contracts. It will be necessary information in conjunction with isEscrowed

Gotcha, thanks! Added the change in TopShot contract

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Create CrossVMBridgeFulfillment.sol contracts
4 participants