-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CrossVMBridgeFulfillment base contracts #168
Conversation
Update: Scoping the extension of ERC721 as a potential for linearization problems in ERC721 extensions - ref |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
==========================================
+ Coverage 86.19% 87.35% +1.15%
==========================================
Files 18 18
Lines 884 1020 +136
==========================================
+ Hits 762 891 +129
- Misses 122 129 +7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm certainly not an authority on Solidity, but this seems fine to me!
FYI @loic1 I've added |
Gotcha, thanks! Added the change in TopShot contract |
Closes: #166
For contributor use:
main
branchFiles changed
in the Github PR explorer