Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLIP 318: VM Bridge Support for Cross-VM NFTs #319

Merged
merged 9 commits into from
Mar 5, 2025

Conversation

sisyphusSmiling
Copy link
Contributor

Related: #318

@sisyphusSmiling sisyphusSmiling added the flip: application Application FLIP label Feb 1, 2025
@sisyphusSmiling sisyphusSmiling self-assigned this Feb 1, 2025
@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review February 1, 2025 00:39
Copy link
Member

@joshuahannan joshuahannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! just a few small comments but I'm definitely on-board. 👍

Co-authored-by: Joshua Hannan <joshua.hannan@dapperlabs.com>
@bluesign
Copy link
Collaborator

bluesign commented Feb 5, 2025

I think for advanced use cases "Router Passthrough" method is much better.

@sisyphusSmiling
Copy link
Contributor Author

@bluesign I can see an eventual future where that's supported. As proposed, the changes are an iterative step in that direction.

What do you think about the proposed design? Or are you suggesting the "router passthrough" alternative should be pursued instead?

@bluesign
Copy link
Collaborator

bluesign commented Feb 6, 2025

No I think current proposal is also very good, but maybe later we can also consider passthrough

@sisyphusSmiling
Copy link
Contributor Author

Update: Added a draft PR to flow-nft defining the proposed views outlined in this FLIP. Feel free to leave feedback specific to how those are implemented on that PR.

@sisyphusSmiling
Copy link
Contributor Author

Update: Base solidity contracts required for Cadence-native NFTs have been implemented, approved and merged - onflow/flow-evm-bridge#168

@bluesign
Copy link
Collaborator

@sisyphusSmiling is there any partner already working or planning to work with new standard?

seeing some real code and use cases can be valuable at this stage imo. For me personally code is much easier to grasp than text, I mean FLIP is pretty detailed and well written, but real world usage can give some new ideas.

@sisyphusSmiling
Copy link
Contributor Author

@bluesign you can see an example of a WIP implementation here - dapperlabs/nba-smart-contracts#281

@sisyphusSmiling
Copy link
Contributor Author

Given all feedback thus far has been positive, I've marked the FLIP as approved and will merge shortly. However, please feel free to chime in with any feedback or questions as implementation continues.

@sisyphusSmiling sisyphusSmiling merged commit 13efb4b into main Mar 5, 2025
@sisyphusSmiling sisyphusSmiling deleted the giovanni/evm-vm-bridge-updates branch March 5, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flip: application Application FLIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants