Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit the CLI when a project step fails #281

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Conversation

ymekuria
Copy link
Collaborator

Fixes #272

The CLI now exits when there is a failure in any step during project creation. We can wait to bump the CLI version until we finish the remaining tasks surrounding the UI scaffold features.

Copy link
Contributor

@jasongitmail jasongitmail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @ymekuria I'll go ahead and merge it

@jasongitmail jasongitmail merged commit 09b8727 into main Oct 24, 2022
@ymekuria ymekuria deleted the fix/exit-on-failure branch November 30, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed NPM install in zk project still gives a success message
3 participants