Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed NPM install in zk project still gives a success message #272

Closed
mitschabaude opened this issue Oct 12, 2022 · 0 comments · Fixed by #281
Closed

Failed NPM install in zk project still gives a success message #272

mitschabaude opened this issue Oct 12, 2022 · 0 comments · Fixed by #281
Assignees
@ymekuria
Labels
berkeley-rampup bug Something isn't working

Comments

@mitschabaude
Copy link
Contributor

moved from o1-labs/o1js#471

$ zk project test_snarkyjs_project
✔ Fetch project template
✔ Initialize Git repo
✖ NPM install
✔ Set project name
✔ Git init commit

Success!

Next steps:
  cd test_snarkyjs_project
  git remote add origin <your-repo-url>
  git push -u origin main
@mitschabaude mitschabaude added berkeley-rampup bug Something isn't working labels Oct 12, 2022
@jasongitmail jasongitmail changed the title Failed NPM install in zk project still gives a success message After each step, check return value and return out, if failed. Oct 13, 2022
@mitschabaude mitschabaude changed the title After each step, check return value and return out, if failed. Failed NPM install in zk project still gives a success message Oct 17, 2022
@ymekuria ymekuria self-assigned this Oct 19, 2022
@ymekuria ymekuria mentioned this issue Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ymekuria ymekuria

Labels
berkeley-rampup bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exit the CLI when a project step fails o1-labs/zkapp-cli
2 participants
@ymekuria @mitschabaude