This repository was archived by the owner on Dec 27, 2024. It is now read-only.
Named containers #351
Merged
Named containers #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
pushed a commit
to cthulhu-rider/neofs-api-go
that referenced
this pull request
Oct 11, 2021
…tegration Define const `SysAttributeName` and `SysAttributeZone` keys to NNS attributes. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider
force-pushed
the
feature/container-names
branch
from
44adfee to
fba67c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 62.98% 63.05% +0.07%
==========================================
Files 120 120
Lines 14110 14138 +28
==========================================
+ Hits 8887 8915 +28
Misses 4216 4216
Partials 1007 1007
Continue to review full report at Codecov.
|
cthulhu-rider
pushed a commit
to cthulhu-rider/neofs-api-go
that referenced
this pull request
Oct 11, 2021
…e names Implement `GetNativeNameWithZone` / `SetNativeNameWithZone` function which gets / sets `__NEOFS_NAME` and `__NEOFS_ZONE` container attributes. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
alexvanin
previously approved these changes
Oct 11, 2021
cthulhu-rider
pushed a commit
to cthulhu-rider/neofs-api-go
that referenced
this pull request
Oct 11, 2021
…e names Implement `GetNativeNameWithZone` / `SetNativeNameWithZone` function which gets / sets `__NEOFS_NAME` and `__NEOFS_ZONE` container attributes. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider
force-pushed
the
feature/container-names
branch
from
7e195a0 to
6171d57
Compare
carpawell
previously approved these changes
Oct 12, 2021
alexvanin
reviewed
Oct 14, 2021
cthulhu-rider
pushed a commit
to cthulhu-rider/neofs-api-go
that referenced
this pull request
Oct 14, 2021
Define `SysAttributeZoneDefault` constant for default zone in V2 code. Add `SetNativeName` function which sets name with default zone. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
added 3 commits
October 14, 2021 11:53
…tegration Define const `SysAttributeName` and `SysAttributeZone` keys to NNS attributes. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
…e names Implement `GetNativeNameWithZone` / `SetNativeNameWithZone` function which gets / sets `__NEOFS_NAME` and `__NEOFS_ZONE` container attributes. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
Define `SysAttributeZoneDefault` constant for default zone in V2 code. Add `SetNativeName` function which sets name with default zone. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider
force-pushed
the
feature/container-names
branch
from
2e5ba5d to
e34edef
Compare
carpawell
approved these changes
Oct 14, 2021
alexvanin
approved these changes
Oct 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on nspcc-dev/neofs-api#177.
Re-compilation TBD