Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work with container names #907

Merged
merged 5 commits into from
Oct 18, 2021
Merged

Work with container names #907

merged 5 commits into from
Oct 18, 2021

Conversation

cthulhu-rider
Copy link
Contributor

No description provided.

@cthulhu-rider cthulhu-rider added enhancement Improving existing functionality neofs-ir Inner Ring node application issues neofs-storage Storage node application issues labels Oct 11, 2021
@cthulhu-rider cthulhu-rider self-assigned this Oct 11, 2021
@codecov
Copy link

codecov bot commented Oct 11, 2021 •
edited
Loading

Codecov Report

Merging #907 (ff1cb17) into master (8efeba8) will increase coverage by 0.08%.
The diff coverage is 0.00%.

❗ Current head ff1cb17 differs from pull request most recent head 720b2ff. Consider uploading reports for the commit 720b2ff to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
+ Coverage   38.85%   38.94%   +0.08%     
==========================================
  Files         250      250              
  Lines       12517    12523       +6     
==========================================
+ Hits         4864     4877      +13     
+ Misses       7248     7241       -7     
  Partials      405      405
Impacted Files Coverage Δ
pkg/morph/event/container/put.go 43.75% <0.00%> (-6.25%) ⬇️
pkg/morph/event/container/put_notary.go 0.00% <0.00%> (ø)
pkg/morph/event/opcodes.go 69.56% <0.00%> (-10.44%) ⬇️
pkg/morph/client/notary.go 0.00% <0.00%> (ø)
cmd/neofs-node/config/morph/config.go 100.00% <0.00%> (ø)
pkg/innerring/processors/netmap/processor.go 0.00% <0.00%> (ø)
pkg/innerring/processors/netmap/process_epoch.go 0.00% <0.00%> (ø)
pkg/morph/client/client.go 7.55% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8efeba8...720b2ff. Read the comment docs.

cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this pull request Oct 12, 2021
[nspcc-dev#907] morph/event: Implement Op to string converter
029a474 
Implement `StringFromOpcode` function that tries to retrieve `string` to
`Op`. Add a comment about neo-go source code that is used for implementation
of converters.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this pull request Oct 12, 2021
[nspcc-dev#907] morph/event/container: Define PutNamed event
eebb816 
Define `PutNamed` structure of notary notification from `putNamed` method of
Container contract. Embed `Put` type in order to inherit methods and
parsing of common parts with `put` method.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this pull request Oct 12, 2021
[nspcc-dev#907] morph/event/container: Parse PutNamed event
2de9c23 
Implement `ParsePutNamedNotary` function which parses `PutNamed` structure
from `event.NotaryEvent`. Share common code with `ParsePutNotary` function.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this pull request Oct 12, 2021
[nspcc-dev#907] morph/container: Add native name and zone to PutArgs
51cf791 
Add `PutArgs.SetNativeNameWithZone` method which sets native name and zone
for container. Call `putNamed` method of Container contract if name is set,
otherwise call `put` method.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this pull request Oct 12, 2021
[nspcc-dev#907] container/put: Work with named containers
05adafc 
Add name and zone arguments to `Put` method of wrapper over the Container
contract client. Pass result of `container.GetNativeNameWithZone` function
to the method in `Put` helper function. Due to this, the storage node will
call the method depending on the presence of the container name in the
attributes.

Make IR to listen `putNamed` notification event. The event is processed like
`put` event, but with sanity check of the container attributes.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider force-pushed the feature/889-container-names branch from 9af56bf to 05adafc Compare October 12, 2021 14:56
@cthulhu-rider cthulhu-rider marked this pull request as ready for review October 12, 2021 14:58
carpawell
carpawell reviewed Oct 12, 2021
View reviewed changes
cthulhu-rider pushed a commit to cthulhu-rider/neofs-node that referenced this pull request Oct 14, 2021
[nspcc-dev#907] container/put: Work with named containers
b0a0386 
Add name and zone arguments to `Put` method of wrapper over the Container
contract client. Pass result of `container.GetNativeNameWithZone` function
to the method in `Put` helper function. Due to this, the storage node will
call the method depending on the presence of the container name in the
attributes.

Make IR to listen `putNamed` notification event. The event is processed like
`put` event, but with sanity check of the container attributes.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider force-pushed the feature/889-container-names branch from 05adafc to b0a0386 Compare October 14, 2021 13:52
Leonard Lyubich added 5 commits October 15, 2021 15:37
[nspcc-dev#907] morph/event: Implement Op to string converter
80b5f54 
Implement `StringFromOpcode` function that tries to retrieve `string` to
`Op`. Add a comment about neo-go source code that is used for implementation
of converters.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
[nspcc-dev#907] morph/event/container: Define PutNamed event
4398e50 
Define `PutNamed` structure of notary notification from `putNamed` method of
Container contract. Embed `Put` type in order to inherit methods and
parsing of common parts with `put` method.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
[nspcc-dev#907] morph/event/container: Parse PutNamed event
4d77aea 
Implement `ParsePutNamedNotary` function which parses `PutNamed` structure
from `event.NotaryEvent`. Share common code with `ParsePutNotary` function.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
[nspcc-dev#907] morph/container: Add native name and zone to PutArgs
993797a 
Add `PutArgs.SetNativeNameWithZone` method which sets native name and zone
for container. Call `putNamed` method of Container contract if name is set,
otherwise call `put` method.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
[nspcc-dev#907] container/put: Work with named containers
720b2ff 
Add name and zone arguments to `Put` method of wrapper over the Container
contract client. Pass result of `container.GetNativeNameWithZone` function
to the method in `Put` helper function. Due to this, the storage node will
call the method depending on the presence of the container name in the
attributes.

Make IR to listen `putNamed` notification event. The event is processed like
`put` event, but with sanity check of the container attributes.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider force-pushed the feature/889-container-names branch from b0a0386 to 720b2ff Compare October 15, 2021 12:42
@alexvanin alexvanin merged commit e0f0188 into nspcc-dev:master Oct 18, 2021
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Mar 5, 2022
@aprasolova
[nspcc-dev#907] morph/event: Implement Op to string converter
14f3a59 
Implement `StringFromOpcode` function that tries to retrieve `string` to
`Op`. Add a comment about neo-go source code that is used for implementation
of converters.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Mar 5, 2022
@aprasolova
[nspcc-dev#907] morph/event/container: Define PutNamed event
a75a1be 
Define `PutNamed` structure of notary notification from `putNamed` method of
Container contract. Embed `Put` type in order to inherit methods and
parsing of common parts with `put` method.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Mar 5, 2022
@aprasolova
[nspcc-dev#907] morph/event/container: Parse PutNamed event
5d52abb 
Implement `ParsePutNamedNotary` function which parses `PutNamed` structure
from `event.NotaryEvent`. Share common code with `ParsePutNotary` function.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Mar 5, 2022
@aprasolova
[nspcc-dev#907] morph/container: Add native name and zone to PutArgs
99a700b 
Add `PutArgs.SetNativeNameWithZone` method which sets native name and zone
for container. Call `putNamed` method of Container contract if name is set,
otherwise call `put` method.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Mar 5, 2022
@aprasolova
[nspcc-dev#907] container/put: Work with named containers
53f6470 
Add name and zone arguments to `Put` method of wrapper over the Container
contract client. Pass result of `container.GetNativeNameWithZone` function
to the method in `Put` helper function. Due to this, the storage node will
call the method depending on the presence of the container name in the
attributes.

Make IR to listen `putNamed` notification event. The event is processed like
`put` event, but with sanity check of the container attributes.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider deleted the feature/889-container-names branch September 30, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carpawell carpawell carpawell approved these changes

@alexvanin alexvanin alexvanin approved these changes

Assignees

@cthulhu-rider cthulhu-rider

Labels
enhancement Improving existing functionality neofs-ir Inner Ring node application issues neofs-storage Storage node application issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Named containers
3 participants
@cthulhu-rider @alexvanin @carpawell