Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encode: escape non-ASCII characters while marshalling #1

Merged
merged 1 commit into from
Sep 15, 2021
Merged

encode: escape non-ASCII characters while marshalling #1

merged 1 commit into from
Sep 15, 2021

Conversation

AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva marked this pull request as draft September 14, 2021 14:25
roman-khimov
roman-khimov requested changes Sep 14, 2021
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to add some note to README saying why this repo exists and how is it different from the original one.

@AnnaShaleva AnnaShaleva force-pushed the fix-unescaping branch 2 times, most recently from 2197af6 to 5773301 Compare September 15, 2021 09:39
roman-khimov
roman-khimov reviewed Sep 15, 2021
View reviewed changes
@AnnaShaleva AnnaShaleva force-pushed the fix-unescaping branch 2 times, most recently from 4269036 to 4d8f22b Compare September 15, 2021 09:57
@AnnaShaleva AnnaShaleva changed the title decode, encode: preserve non-ASCII characters unescaping encode: escape non-ASCII characters while marshalling Sep 15, 2021
@AnnaShaleva
Copy link
Member Author

@roman-khimov, I added README update in a separate PR not to mix the things, see #2.

@AnnaShaleva AnnaShaleva marked this pull request as ready for review September 15, 2021 10:05
@roman-khimov roman-khimov merged commit e1b6cce into nspcc-dev:master Sep 15, 2021
This was referenced Sep 15, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@fyrchik fyrchik Awaiting requested review from fyrchik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnnaShaleva @roman-khimov